From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Hogan Subject: Re: [PATCH] Fix end_of_stack() fn and location of stack canary for archs using STACK_GROWSUP Date: Fri, 19 Sep 2014 12:21:37 +0100 Message-ID: <541C11C1.2060105@imgtec.com> References: <20140916023736.49db964e@as> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140916023736.49db964e@as> Sender: linux-parisc-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Chuck Ebbert , Helge Deller Cc: linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, Aaron Tomlin , linux-metag Hi Chuck, On 16/09/14 08:37, Chuck Ebbert wrote: > static inline unsigned long *end_of_stack(struct task_struct *p) > { > +#ifdef CONFIG_STACK_GROWSUP > + return (unsigned long *)((unsigned long)task_thread_info(p) + THREAD_SIZE) - 1; Nit: this line should probably be wrapped to 80 columns. Other than that, I've tested this on metag and can confirm that it fixes the following BUG which you would otherwise get during boot with Aaron's patches: BUG: failure at kernel/sched/core.c:2664/schedule_debug()! Kernel panic - not syncing: BUG! Tested-by: James Hogan [metag] Acked-by: James Hogan Aaron: please can you try to get this patch applied before your patch series. Thanks James From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Hogan Subject: Re: [PATCH] Fix end_of_stack() fn and location of stack canary for archs using STACK_GROWSUP Date: Fri, 19 Sep 2014 12:21:37 +0100 Message-ID: <541C11C1.2060105@imgtec.com> References: <20140916023736.49db964e@as> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Cc: , , "Aaron Tomlin" , linux-metag To: Chuck Ebbert , Helge Deller Return-path: In-Reply-To: <20140916023736.49db964e@as> List-ID: List-Id: linux-parisc.vger.kernel.org Hi Chuck, On 16/09/14 08:37, Chuck Ebbert wrote: > static inline unsigned long *end_of_stack(struct task_struct *p) > { > +#ifdef CONFIG_STACK_GROWSUP > + return (unsigned long *)((unsigned long)task_thread_info(p) + THREAD_SIZE) - 1; Nit: this line should probably be wrapped to 80 columns. Other than that, I've tested this on metag and can confirm that it fixes the following BUG which you would otherwise get during boot with Aaron's patches: BUG: failure at kernel/sched/core.c:2664/schedule_debug()! Kernel panic - not syncing: BUG! Tested-by: James Hogan [metag] Acked-by: James Hogan Aaron: please can you try to get this patch applied before your patch series. Thanks James