From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Bader Subject: Re: [PATCH] libxl: Implement basic video device selection Date: Fri, 19 Sep 2014 14:52:13 +0200 Message-ID: <541C26FD.3060404@canonical.com> References: <1411048512-13045-1-git-send-email-stefan.bader@canonical.com> <541B9C8F.9040905@suse.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5240918432037989491==" Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XUxfy-0007MV-0J for xen-devel@lists.xenproject.org; Fri, 19 Sep 2014 12:52:38 +0000 In-Reply-To: <541B9C8F.9040905@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jim Fehlig Cc: libvir-list@redhat.com, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============5240918432037989491== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Sxw89hPnQ7IDw0m88CaeWIiPjOBgP6FR2" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Sxw89hPnQ7IDw0m88CaeWIiPjOBgP6FR2 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 19.09.2014 05:01, Jim Fehlig wrote: > Stefan Bader wrote: >> Re-pushing this as the old thread got rather stale. >=20 > Thanks. >=20 >> Some of the >> VFB setup went in a bug fix. Not sure I missed a detail in rebasing >> bug the keyboard setting may be the only thing missing... >> =20 >=20 > Yes, agreed. >=20 >> -Stefan >> >> [v2: Check return code of VIR_STRDUP and fix indentation] >> [v3: Split out VRAM fixup and return error for unsupported video type]= >> [v4: Re-arrange code and move VFB setup into libxlMakeVfbList] >> [v5: Rebased against head which already had some VFB setup code] >> >> >From b3ff8f4c658d29f15e673af88b9ae2fdfa3c1317 Mon Sep 17 00:00:00 200= 1 >> From: Stefan Bader >> Date: Thu, 27 Mar 2014 16:01:18 +0100 >> Subject: [PATCH] libxl: Implement basic video device selection >> >> This started as an investigation into an issue where libvirt (using th= e >> libxl driver) and the Xen host, like an old couple, could not agree on= >> who is responsible for selecting the VNC port to use. >> >> Things usually (and a bit surprisingly) did work because, just like th= at >> old couple, they had the same idea on what to do by default. However i= t >> was possible that this ended up in a big argument. >> >> The problem is that display information exists in two different places= : >> in the vfbs list and in the build info. And for launching the device m= odel, >> only the latter is used. But that never gets initialized from libvirt.= So >> Xen allows the device model to select a default port while libvirt thi= nks >> it has told Xen that this is done by libvirt (though the vfbs config).= >> >> While fixing that, I made a stab at actually evaluating the configurat= ion >> of the video device. So that it is now possible to at least decide bet= ween >> a Cirrus or standard VGA emulation and to modify the VRAM within certa= in >> limits using libvirt. >> >> Signed-off-by: Stefan Bader >> --- >> src/libxl/libxl_conf.c | 50 +++++++++++++++++++++++++++++++++++++++++= +++++++++ >> 1 file changed, 50 insertions(+) >> =20 >=20 > This patch suffers the same issues as the last version. And when > commenting on that version, I promised to work on a followup to address= > my concerns >=20 > https://www.redhat.com/archives/libvir-list/2014-July/msg00931.html Oh my, I have to admit I completely forgot about that. >=20 > Your repost poked me into reworking my first attempt, the result of > which is below. I should probably look at a sensible split-up of these= > patches that would be easier to review, but in the meantime comments on= > my followup would be appreciated. >=20 > With both patches, my tests are passing and my concerns are subdued :-)= =2E There seem to be some parts of code suggesting support for anything besid= e Xen (assumed to be alias to VGA) and Cirrus. As much as I know Xen handles on= ly the two (not qxl or anything else). I believe the xen specific qemu variant was the only one called qemu-dm (= and the upstream variant always being qemu-system-i386). But checking the help me= ssage probably is safer and not called that often so I should not worry about performance). I tried the variant you proposed and it looks to be ok. Still have to car= ry a piece which is not going upstream if I wan't to paper over the virt-manag= er issue. But at least now the failure is clearly showing what is wrong. So = I am happy enough. :) -Stefan >=20 > Regards, > Jim > =20 >=20 --Sxw89hPnQ7IDw0m88CaeWIiPjOBgP6FR2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJUHCcQAAoJEOhnXe7L7s6j/dUP/iotOHbrgSTVDGgzMpstBb2L KTNEmEeyqiwhfbbQyj6qkyNamgb1tdYopfjkkEn+Z/B5+fmT2ranE/4juHHYnqWn mw6Te7O6LaA3JoHh8wMUK8YisNiImgJisD5ASQo3Yufg5dbRnT633eV8C9b7l+7D x3UpB8kFoQ5yI11iBV5lwV5R+vUYw/DZPmpa8KuXERRV8YGb7ZMAU4+Ve6HqgtZN tanNRPBQI7mJD6VTmlUCkU2SIMVgV6rMFxy9pyEXMHV95NvtMojuOgRaEgx88bHM idGRItwrf4MMqNqDquBfjrissOE+eLySkn/95XLcOEAWqATEwzMAdJ/Tvtp1LQq+ ZTcLTrx/sCatvRd7k8BCXuePcOI40xVG18ijO0MtI6837QyyCO1Ghro7S2A0BAKT uHljmnAF5BwwbDpOg1+XnjdFpNwP7wQ2KMKqBpcG50QFgize3xtRys1gaWkOc5XE qFSg8STQ3U3EYViJZXarX66/8L5FYD5DBwVssXtdcPFOasEWSGyuZMrrrDVvYDwn zGPtZNX1oWZ9ih4+YVSy3FRorfadpaLuam32nUVpqCFwzErHgcXsWIxlGtFcOpMB GWhPp+vw7c8F7UplR5pHF8DVRAYIcF9Zv1upbow4l4XHF/I53y8Em+97DJ2M3s/2 0LY2ox7RWrmsUY/Nnymp =sljX -----END PGP SIGNATURE----- --Sxw89hPnQ7IDw0m88CaeWIiPjOBgP6FR2-- --===============5240918432037989491== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============5240918432037989491==--