From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 1/1] KVM: correct null pid check in kvm_vcpu_yield_to() Date: Fri, 19 Sep 2014 15:33:45 +0200 Message-ID: <541C30B9.2010603@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Sam Bobroff , gleb@kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:52488 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753398AbaISNd7 (ORCPT ); Fri, 19 Sep 2014 09:33:59 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: Il 19/09/2014 01:40, Sam Bobroff ha scritto: > Correct a simple mistake of checking the wrong variable > before a dereference, resulting in the dereference not being > properly protected by rcu_dereference(). > > Signed-off-by: Sam Bobroff > --- > > virt/kvm/kvm_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 33712fb..688acb0 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -1725,7 +1725,7 @@ int kvm_vcpu_yield_to(struct kvm_vcpu *target) > rcu_read_lock(); > pid = rcu_dereference(target->pid); > if (pid) > - task = get_pid_task(target->pid, PIDTYPE_PID); > + task = get_pid_task(pid, PIDTYPE_PID); > rcu_read_unlock(); > if (!task) > return ret; > Thanks, applying to kvm/master. Paolo