From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46750) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XV4z2-0003iM-7E for qemu-devel@nongnu.org; Fri, 19 Sep 2014 16:40:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XV4ys-0003ac-Sd for qemu-devel@nongnu.org; Fri, 19 Sep 2014 16:40:48 -0400 Received: from cantor2.suse.de ([195.135.220.15]:38597 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XV4ys-0003Yd-FS for qemu-devel@nongnu.org; Fri, 19 Sep 2014 16:40:38 -0400 Message-ID: <541C94BC.6080106@suse.de> Date: Fri, 19 Sep 2014 22:40:28 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1409733914-1272-1-git-send-email-eric.auger@linaro.org> <20140919090331.GA27501@stefanha-thinkpad.redhat.com> <541C54A6.5080506@linaro.org> In-Reply-To: <541C54A6.5080506@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC] vfio: migration to trace points List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Auger , Stefan Hajnoczi Cc: peter.maydell@linaro.org, kim.phillips@freescale.com, eric.auger@st.com, patches@linaro.org, aik@ozlabs.ru, qemu-devel@nongnu.org, a.rigo@virtualopensystems.com, Bharat.Bhushan@freescale.com, bsd@redhat.com, alex.williamson@redhat.com, kraxel@redhat.com, stuart.yoder@freescale.com, pbonzini@redhat.com, kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org On 19.09.14 18:07, Eric Auger wrote: > Hi Stefan, > > Thanks for asking. Actually I think this is a bit early. I would like > some VFIO PCI users experiencing it a little bit (typically Alex) and > confirm they are happy with it. Don't be so reluctant - this patch is a step forward, so just mark it as a real patch. There's nothing controversial in here. > > Also as I mentionned in the commit message, I identified some parsing > issues that forced me to change few format strings. I don't know if you > have time or are willing to fix those - you may be more efficient doing > those fixes than I would;-) - Nethertheless if you can't afford, I will > have a look at the Python code. > > For convenience I put the issues again, all related to parenthesis: > > Cases than are not correctly handled are given below: > - "(%04x:%02x:%02x.%x)" need to be replaced by " (%04x:%02x:%02x.%x)" > - "%s read(%04x:%02x:%02x.%x:BAR%d+0x%"PRIx64", %d) = 0x%"PRIx64 replaced by > "%s read(%04x:%02x:%02x.%x:BAR%d+0x%"PRIx64", %d = 0x%"PRIx64 > - "%s write(%04x:%02x:%02x.%x:BAR%d+0x%"PRIx64", 0x%"PRIx64", %d)" > replaced by > "%s write(%04x:%02x:%02x.%x:BAR%d+0x%"PRIx64", 0x%"PRIx64", %d" Looks like cosmetic problems that can be solved later :). Alex