Re: [Qemu-devel] [PATCH] chardev: Add reconnecting to client sockets

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1658 bytes --]

On 09/19/2014 03:58 PM, minyard@acm.org wrote:
> From: Corey Minyard <cminyard@mvista.com>
> 
> Adds a "recon" option to socket backends that gives a reconnect
> timeout.  This only applies to client sockets.  If the other end
> of a socket closes the connection, qemu will attempt to reconnect
> after the given number of seconds.
> 
> This rearranges things a bit, all socket configuration is moved to
> qmp_chardev_open_socket() and that only gets called once at startup.
> qemu_chr_open_socket_fd() is called to open or re-open the connection.
> 
> Signed-off-by: Corey Minyard <cminyard@mvista.com>
> ---
>  qapi-schema.json |   6 +-
>  qemu-char.c      | 209 +++++++++++++++++++++++++++++++++++++++++--------------
>  qemu-options.hx  |  20 ++++--
>  3 files changed, 174 insertions(+), 61 deletions(-)
> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 689b548..f42562f 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -2648,6 +2648,9 @@
>  # @nodelay: #optional set TCP_NODELAY socket option (default: false)
>  # @telnet: #optional enable telnet protocol on server
>  #          sockets (default: false)
> +# @recon: #optional If not a server socket, if the socket disconnect
> +#          then reconnect after the given number of seconds.  Setting
> +#          to zero disables this function. (default: 0)

"recon" makes me think of spy novels, not reconnect.  Any reason you
can't name it something more descriptive, like "reconnect-time"?

Missing a "since 2.2" designation.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]