From: Antonio Quartulli <antonio@meshcoding.com>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: avoid NULL dereferences and clarify if check
Date: Sat, 20 Sep 2014 18:17:56 +0200 [thread overview]
Message-ID: <541DA8B4.5000107@meshcoding.com> (raw)
In-Reply-To: <1410937316-23199-1-git-send-email-antonio@meshcoding.com>
[-- Attachment #1: Type: text/plain, Size: 323 bytes --]
Hi all,
On 17/09/14 09:01, Antonio Quartulli wrote:
> gw_node = batadv_gw_node_get(bat_priv, orig_dst_node);
> - if (!gw_node->bandwidth_down == 0)
> + if (!gw_node || (gw_node->bandwidth_down == 0))
This is not the right way to fix this condition. A new patch is coming.
Cheers,
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-09-20 16:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 7:01 [B.A.T.M.A.N.] [PATCH maint] batman-adv: avoid NULL dereferences and clarify if check Antonio Quartulli
2014-09-20 16:17 ` Antonio Quartulli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541DA8B4.5000107@meshcoding.com \
--to=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.