Re: Re: [PATCH v4 1/4] ftracetest: Initial commit for ftracetest

[Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>]

(2014/09/19 23:05), Shuah Khan wrote:
>>>> +TODO
>>>> +====
>>>> +
>>>> + * Fancy colored output :)
>>>> +
>>>> + * Integrate with selftest?
>>>
>>> The second TODO can be removed since it is moved under selftests??
>>
>> Ah, I missed to remove that in this commit. It's already integrated.
>>
>> - * Integrate with selftest?
>>
>> Oops, and I removed it in 4/4 ...
> 
> If you could fix this README, that would be great.

Yeah, but I guess if all of this series are merged, it may be not
such a big flaw...
Steven, would I better resend updates?

>>> If you haven't already done this, could you please make sure it
>>> runs without hangs when run from the "make kselftest" target.
>>
>> OK, here is the last lines of the test result.
>>
>> == Testing sysctl behavior against /proc/sys/vm/swappiness ==
>> Writing test file ... ok
>> Checking sysctl is not set to test value ... ok
>> Writing sysctl from shell ... ok
>> Resetting sysctl to original value ... ok
>> Writing entire sysctl in single write ... ok
>> Writing middle of sysctl after synchronized seek ... Writing beyond end of sysctl ... Writing sysctl with multiple long writes ... ok
>> fw_filesystem: [FAIL]
>> [1] Basic trace file check      [PASS]
>> [2] Basic test for tracers      [PASS]
>> [3] Basic trace clock test      [PASS]
>> [4] Kprobe dynamic event - adding and removing  [PASS]
>> [5] Kprobe dynamic event - busy event check     [PASS]
>>
>> # of passed:  5
>> # of failed:  0
>> # of unresolved:  0
>> # of untested:  0
>> # of unsupported:  0
>> # of xfailed:  0
>> # of undefined(test bug):  0
>>
>> Hmm, I think it should have a separation line before running ftracetest.
>>
> 
> I am not concerned about the spacing.

OK, anyway I can make an update for that afterwords.

> Thanks for doing running the make kselftest target and sharing
> the results. selftests don't get built or run in integ test
> rings. I am working on addressing this at the moment.
> 
> Steven!
> 
> Could you please take this through your tree. You have my
> 
> Acked-by: Shuah Khan <shuahkh@osg.samsung.com>
> 
> for the selftests Makefile

Thanks!

> 
> -- Shuah
> 


-- 
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Research Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com