All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: TR Reardon <thomas_reardon@hotmail.com>,
	"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: resize2fs problem with stride calc
Date: Sun, 21 Sep 2014 11:13:06 -0500	[thread overview]
Message-ID: <541EF912.7000801@redhat.com> (raw)
In-Reply-To: <BAY179-W85AF983234DB78F07A12EFDB50@phx.gbl>

On 9/20/14 3:46 PM, TR Reardon wrote:
> resize2fs seems to come up with some crazy default stride numbers.
> This occurs with and without bigalloc.
> 
> 
> I was testing enabling/disabling 64bit using latest patches from DJW,
> and noticed that s_raid_stride was being written with nonsensical
> values, in particular determine_fs_stride() is coming up with overly
> large values.  The code is old (2006) and lacks comment so I'm not
> sure what the intended operation is.  Does this just need to be
> updated for flex_bg?  Should s_raid_stride ever be auto-changed on
> resize?  If it should change, should stripe also change?

That old commit says:

+               In addition, add code so that resize2fs can automatically
+               determine the RAID stride parameter that had been
+               previously used on the filesystem.

but a year later, in 2007, this:

commit 96c6a3acd377698cb99ffd9925bec9b20ca4f6f9
Author: Theodore Ts'o <tytso@mit.edu>
Date:   Fri May 18 22:06:53 2007 -0400

    Store the RAID stride value in the superblock and take advantage of it

stored it properly in the superblock (this hit e2fsprogs-1.40).

So maybe the whole heuristic could just be removed now, but from a simple
test, it's working here.

What was the geometry (dumpe2fs -h) of your filesystem before the resize?

-Eric

  reply	other threads:[~2014-09-21 16:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-20 20:46 resize2fs problem with stride calc TR Reardon
2014-09-21 16:13 ` Eric Sandeen [this message]
2014-09-21 22:32   ` TR Reardon
2014-09-29 20:59     ` Darrick J. Wong
2014-09-29 22:46       ` Andreas Dilger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=541EF912.7000801@redhat.com \
    --to=sandeen@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=thomas_reardon@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.