All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] grub-mkrescue: remove temporary load_cfg file
Date: Sun, 21 Sep 2014 19:08:45 +0200	[thread overview]
Message-ID: <541F061D.9090409@gmail.com> (raw)
In-Reply-To: <1398961019-29913-1-git-send-email-arvidjaar@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 921 bytes --]

I actually like to have load.cfg around: it helps with debugging in some
cases. Do you have a reason to remove it?
On 01.05.2014 18:16, Andrey Borzenkov wrote:
> ---
>  util/grub-mkrescue.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/util/grub-mkrescue.c b/util/grub-mkrescue.c
> index e719839..c3d9b32 100644
> --- a/util/grub-mkrescue.c
> +++ b/util/grub-mkrescue.c
> @@ -323,6 +323,7 @@ make_image_fwdisk_abs (enum grub_install_plat plat,
>    grub_install_make_image_wrap (source_dirs[plat], "()/boot/grub", output,
>  				0, load_cfg, mkimage_target, 0);
>    grub_install_pop_module ();
> +  grub_util_unlink (load_cfg);
>  }
>  
>  static int
> @@ -566,6 +567,7 @@ main (int argc, char *argv[])
>  	}
>        grub_install_pop_module ();
>        grub_install_pop_module ();
> +      grub_util_unlink (load_cfg);
>      }
>  
>    /** build multiboot core.img */
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]

  reply	other threads:[~2014-09-21 17:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-01 16:16 [PATCH] grub-mkrescue: remove temporary load_cfg file Andrey Borzenkov
2014-09-21 17:08 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2014-09-22 18:32   ` Andrei Borzenkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=541F061D.9090409@gmail.com \
    --to=phcoder@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.