From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1XVlef-0000JF-8e for mharc-grub-devel@gnu.org; Sun, 21 Sep 2014 14:14:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55582) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XVlec-0000J3-3W for grub-devel@gnu.org; Sun, 21 Sep 2014 14:14:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XVlea-0007Kv-QO for grub-devel@gnu.org; Sun, 21 Sep 2014 14:14:34 -0400 Received: from mail-we0-x230.google.com ([2a00:1450:400c:c03::230]:51764) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XVlea-0007KR-Fp for grub-devel@gnu.org; Sun, 21 Sep 2014 14:14:32 -0400 Received: by mail-we0-f176.google.com with SMTP id w61so1015531wes.35 for ; Sun, 21 Sep 2014 11:14:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=W5jpnHSYVO7h+y4FvVu/R1vXY3SIX3V0wPymmvG3VEg=; b=KK1/+z2PAoN2lAd8Ds2Fmj6NZnJ2HkQgBk3JaV1lljIsuY228dt+vCv4lyG6slQ/X0 G9kBHa62jm6upCNC17Zdss47vN/X805FtQl/sJNf+eHsFnxaOebAUFycEimbASeQKqab FpgZa/7m4CpAjEMp6fUK+TR/IlRU+3oUQo7O3nth9eUYfxVIW+ryzPiMapKcYEgMX/kF 1WB1YUzvfGXl+ww+HcM/rVyE19b3FoePtjb16CjLdLDRS2BUEH7izHvyS4f4bKwDxcjD omENztIYrdTa2nO3jYduZegZ+imlSuoK9QjfiHALD4VKRmMHFVtE5p93LMtHp5SB+q+p +hSw== X-Received: by 10.180.211.36 with SMTP id mz4mr10506187wic.39.1411323266427; Sun, 21 Sep 2014 11:14:26 -0700 (PDT) Received: from ?IPv6:2a02:1205:501d:9350:863a:4bff:fe50:abc4? ([2a02:1205:501d:9350:863a:4bff:fe50:abc4]) by mx.google.com with ESMTPSA id lu12sm9446848wic.4.2014.09.21.11.14.25 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 Sep 2014 11:14:25 -0700 (PDT) Message-ID: <541F1580.2020005@gmail.com> Date: Sun, 21 Sep 2014 20:14:24 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.0 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [RFC PATCH] configure check for ld's --no-relax flag References: <1406895356-28090-1-git-send-email-stanislav.kholmanskikh@oracle.com> <20140801193559.61fe4363@opensuse.site> <53DBB4D4.3090508@gmail.com> <53DF2C02.4030607@oracle.com> <20140804185346.22e2f581@opensuse.site> <541F04CC.3040509@gmail.com> <20140921215030.1af8c476@opensuse.site> In-Reply-To: <20140921215030.1af8c476@opensuse.site> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tAKCFh6CNNSTRGwlGNS4HQnf438AihaxF" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c03::230 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Sep 2014 18:14:35 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --tAKCFh6CNNSTRGwlGNS4HQnf438AihaxF Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 21.09.2014 19:50, Andrei Borzenkov wrote: > =D0=92 Sun, 21 Sep 2014 19:03:08 +0200 > Vladimir '=CF=86-coder/phcoder' Serbinenko =D0=BF=D0= =B8=D1=88=D0=B5=D1=82: >=20 >> On 04.08.2014 16:53, Andrey Borzenkov wrote: >>> =D0=92 Mon, 04 Aug 2014 10:45:22 +0400 >>> Stanislav Kholmanskikh =D0=BF=D0=B8= =D1=88=D0=B5=D1=82: >>> >>>> Hi! >>>> >>>> On 08/01/2014 07:40 PM, Vladimir '=CF=86-coder/phcoder' Serbinenko w= rote: >>>>> On 01.08.2014 17:35, Andrey Borzenkov wrote: >>>>>> =D0=92 Fri, 1 Aug 2014 16:15:56 +0400 >>>>>> Stanislav Kholmanskikh =D0=BF=D0= =B8=D1=88=D0=B5=D1=82: >>>>>> >>>>>>> Early versions of binutils doesn't support --no-relax flag, so >>>>>>> commit 063f2a04d158ec1b275a925dfbae74b124708cde prevents building= >>>>>>> with such versions. >>>>>>> >>>>>>> Signed-off-by: Stanislav Kholmanskikh >>>>>>> --- >>>>>>> conf/Makefile.common | 8 ++++++++ >>>>>>> configure.ac | 10 ++++++++++ >>>>>>> 2 files changed, 18 insertions(+), 0 deletions(-) >>>>>>> >>>>>>> diff --git a/conf/Makefile.common b/conf/Makefile.common >>>>>>> index e4c301f..5bda66f 100644 >>>>>>> --- a/conf/Makefile.common >>>>>>> +++ b/conf/Makefile.common >>>>>>> @@ -8,11 +8,19 @@ unexport LC_ALL >>>>>>> # Platform specific options >>>>>>> if COND_sparc64_ieee1275 >>>>>>> CFLAGS_PLATFORM +=3D -mno-app-regs >>>>>>> +if COND_LD_SUPPORTS_NO_RELAX >>>>>>> LDFLAGS_PLATFORM =3D -Wl,-melf64_sparc -Wl,--no-relax >>>>>>> +else >>>>>>> + LDFLAGS_PLATFORM =3D -Wl,-melf64_sparc -mno-relax >>>>>>> +endif >>>>>> >>>>>> TBO I think commit should simply be reverted. "Uniformity" is rath= er >>>>>> poor excuse for breaking existing systems. >>>>>> >>>>> This commit is needed for clang to compile for sparc64. Given that >>>>> sparc64 clang still doesn't really work I'm ok with reverting, at l= east >>>>> for now. >>>> >>>> But, it this case, maybe it would be better to consider=20 >>>> reviewing/applying this patch? Just to not return to this issue afte= r=20 >>>> some time? >>>> >>>> Andrey, Vladimir, what do you think? >>>> >>> >>> Yes, commit message was pretty confusing. This leaves the question, >>> whether combination of clang and binutils that do not support >>> -Wl,--no-relax exists though :) Otherwise I agree, we should use this= >>> patch. >>> >> I think we could try to push for clang to have -mno-relax. They're >> usually pretty responsive and we'll probably need few fixes for few >> other clang problems anyway. For now I just reverted it. >=20 > Did you push it? >=20 Now yes. I was offline when I wrote this. My mail automatically sent this when I got online but git needed manual intervention. >=20 >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 --tAKCFh6CNNSTRGwlGNS4HQnf438AihaxF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iF4EAREKAAYFAlQfFYAACgkQmBXlbbo5nOt7yQD6Ak7dE0vPp3JJbN1YdRHvSCy2 gyDfiHmYcSUFK7calvsA/AlNfPsWGzQYYScDGqwO5DANjTmzKj8an4QAK4J8hFev =alt6 -----END PGP SIGNATURE----- --tAKCFh6CNNSTRGwlGNS4HQnf438AihaxF--