From: Paolo Bonzini <pbonzini@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] kvm: Make init_rmode_tss() return 0 on success.
Date: Mon, 22 Sep 2014 11:17:34 +0200 [thread overview]
Message-ID: <541FE92E.9010004@redhat.com> (raw)
In-Reply-To: <20140919234440.GA2501@potion.redhat.com>
Il 20/09/2014 01:44, Radim Krčmář ha scritto:
>> > This patch removes the redundant variable, by making init_rmode_tss()
>> > return 0 on success, -errno on failure.
> Which is going to propagate all the way to userpace through ioctl ...
> is this change of A[PB]I acceptable?
>
> Otherwise, -EFAULT seems to match unlikely problems better than -ENOMEM,
> so if it is acceptable: Reviewed-by: Radim Krčmář <rkrcmar@redhat.com>
Yes, I think it is a bugfix.
Paolo
prev parent reply other threads:[~2014-09-22 9:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 11:38 [PATCH] kvm: Make init_rmode_tss() return 0 on success Paolo Bonzini
2014-09-19 23:44 ` Radim Krčmář
2014-09-22 9:17 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541FE92E.9010004@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.