From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53355) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XW0fe-0007mp-K9 for qemu-devel@nongnu.org; Mon, 22 Sep 2014 06:16:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XW0fZ-0001OU-Q6 for qemu-devel@nongnu.org; Mon, 22 Sep 2014 06:16:38 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:59024) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XW0fZ-0001Ny-LM for qemu-devel@nongnu.org; Mon, 22 Sep 2014 06:16:33 -0400 Message-ID: <541FF6F8.3030906@citrix.com> Date: Mon, 22 Sep 2014 11:16:24 +0100 From: David Vrabel MIME-Version: 1.0 References: <1411376699-8175-1-git-send-email-owen.smith@citrix.com> <1411376699-8175-3-git-send-email-owen.smith@citrix.com> In-Reply-To: <1411376699-8175-3-git-send-email-owen.smith@citrix.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xenfb: Add comment documentation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Owen smith , xen-devel@lists.xen.org Cc: ian.campbell@citrix.com, qemu-devel@nongnu.org, stefano.stabellini@eu.citrix.com On 22/09/14 10:04, Owen smith wrote: > Add documentation for page-ref, page-gref and event-channel. > > Signed-off-by: Owen smith > --- > xen/include/public/io/fbif.h | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/xen/include/public/io/fbif.h b/xen/include/public/io/fbif.h > index cc25aab..ba3f524 100644 > --- a/xen/include/public/io/fbif.h > +++ b/xen/include/public/io/fbif.h > @@ -26,6 +26,31 @@ > #ifndef __XEN_PUBLIC_IO_FBIF_H__ > #define __XEN_PUBLIC_IO_FBIF_H__ > > +/* > + * Frontend XenStore Nodes > + * ----------------------- > + * > + * page-ref > + * Values: > + * Optional, "page-gref" is used if "page-ref" is not set. > + * > + * The MFN of a page of memory for the shared ring structures. If not > + * present, "page-gref" must be set.page-ref" overrides "page-gref". I think you mean GFN here, not MFN. > + * page-gref > + * Values: > + * Only required if "page-ref" is NOT set. > + * > + * A grant reference to the memory page to be mapped for the shared ring > + * structures. Must be present if "page-ref" is not present. Should there be some negotiation for which of page-ref or page-gref is required/preferred by the backend? The same applies to kbdif as well. David From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH 2/2] xenfb: Add comment documentation Date: Mon, 22 Sep 2014 11:16:24 +0100 Message-ID: <541FF6F8.3030906@citrix.com> References: <1411376699-8175-1-git-send-email-owen.smith@citrix.com> <1411376699-8175-3-git-send-email-owen.smith@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1411376699-8175-3-git-send-email-owen.smith@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Owen smith , xen-devel@lists.xen.org Cc: ian.campbell@citrix.com, qemu-devel@nongnu.org, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 22/09/14 10:04, Owen smith wrote: > Add documentation for page-ref, page-gref and event-channel. > > Signed-off-by: Owen smith > --- > xen/include/public/io/fbif.h | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/xen/include/public/io/fbif.h b/xen/include/public/io/fbif.h > index cc25aab..ba3f524 100644 > --- a/xen/include/public/io/fbif.h > +++ b/xen/include/public/io/fbif.h > @@ -26,6 +26,31 @@ > #ifndef __XEN_PUBLIC_IO_FBIF_H__ > #define __XEN_PUBLIC_IO_FBIF_H__ > > +/* > + * Frontend XenStore Nodes > + * ----------------------- > + * > + * page-ref > + * Values: > + * Optional, "page-gref" is used if "page-ref" is not set. > + * > + * The MFN of a page of memory for the shared ring structures. If not > + * present, "page-gref" must be set.page-ref" overrides "page-gref". I think you mean GFN here, not MFN. > + * page-gref > + * Values: > + * Only required if "page-ref" is NOT set. > + * > + * A grant reference to the memory page to be mapped for the shared ring > + * structures. Must be present if "page-ref" is not present. Should there be some negotiation for which of page-ref or page-gref is required/preferred by the backend? The same applies to kbdif as well. David