From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53527) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XW2MR-0007eV-5D for qemu-devel@nongnu.org; Mon, 22 Sep 2014 08:05:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XW2MJ-0005lL-Kr for qemu-devel@nongnu.org; Mon, 22 Sep 2014 08:04:55 -0400 Received: from cantor2.suse.de ([195.135.220.15]:43402 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XW2MJ-0005kk-Ea for qemu-devel@nongnu.org; Mon, 22 Sep 2014 08:04:47 -0400 Message-ID: <5420105C.2090701@suse.de> Date: Mon, 22 Sep 2014 14:04:44 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1411385195-13495-1-git-send-email-lersek@redhat.com> <1411385195-13495-3-git-send-email-lersek@redhat.com> In-Reply-To: <1411385195-13495-3-git-send-email-lersek@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/2] machine_parse(): list supported machine types in their registration order List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek , qemu-devel@nongnu.org, marcel.a@redhat.com, mst@redhat.com, peter.maydell@linaro.org Am 22.09.2014 um 13:26 schrieb Laszlo Ersek: > Based on the registration order captured in the previous patch, we sort > the ad-hoc list printed for >=20 > qemu-system-XXXX -M \? Agree that the order is worth sanitizing. I would however argue that registration order is not entirely stable either if you think of non-PC cases where there's dozens of source files registering one machine each. I would therefore propose alphabetical order as we do for QOM'ified CPUs. > The GLib documentation is not overly clear if g_slist_sort() allocates = a > new list or reorders the input list in place, but: > - it slightly suggests the latter, > - and there is prior use in qemu that is consistent with the latter: > g_slist_sort() in qdev_print_devinfos() [qdev-monitor.c] sorts the > return value of object_class_get_list() the same as we do here in > machine_parse(). I believe I also assumed that for -cpu ? and/or QMP. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg