From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <dslutz@verizon.com>
Subject: Re: [PATCH for-4.5 v6 05/16] tools: Add vmware_port
	support
Date: Mon, 22 Sep 2014 12:42:35 -0400
Message-ID: <5420517B.9060602@terremark.com>
References: <1411236447-7435-1-git-send-email-dslutz@verizon.com>	
	<1411236447-7435-6-git-send-email-dslutz@verizon.com>
	<1411393315.18331.104.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1411393315.18331.104.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>, Don Slutz <dslutz@verizon.com>
Cc: Tim Deegan <tim@xen.org>, Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>, Jun Nakajima <jun.nakajima@intel.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Eddie Dong <eddie.dong@intel.com>, xen-devel@lists.xen.org, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>, Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
List-Id: xen-devel@lists.xenproject.org


On 09/22/14 09:41, Ian Campbell wrote:
> On Sat, 2014-09-20 at 14:07 -0400, Don Slutz wrote:
>> This new libxl_domain_create_info field is used to set
>> XEN_DOMCTL_CDF_vmware_port for the xc_domain_create() routine.
> Does this really need to be a CDF, rather than a domctl/hvm param?

It makes the setting up of v->arch.hvm_vmx.exception_bitmap happen at 
the right
time.  domctl/hvm param happen later in the start of a domain.

> The latter would allow moving to buildinfo.u.hvm, which would be nicer
> from the libxl PoV, I think.

I could not find "buildinfo.u.hvm":


dcs-xen-54:~/xen>git grep buildinfo.u.hvm
dcs-xen-54:~/xen>


So unable to comment.


>> In xen it is is_vmware_port_enabled.
>>
>> If is_vmware_port_enabled then
>>    enable a limited support of VMware's hyper-call.
>>
>> VMware's hyper-call is also known as VMware Backdoor I/O Port.
>>
>> Signed-off-by: Don Slutz <dslutz@verizon.com>
> Is it useful to be able to configure this independently of the vmware_hw
> version?

Yes.

> If yes then I still think you would want to set the default based on
> vmware-hw, wouldn't you?

I guess so since this is a BOOLEAN.  Currently I do not know of a way to 
say "set vmware_hw to 7
if vmware_port is true and vmware_hw is not specified".  Which would be 
the inverse.  I lean to
not having the default of vmware_port based on vmware_hw.

    -Don Slutz


> Ian.
>