From: Florian Fainelli <f.fainelli@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net 0/2] net: bcmgenet: TX reclaim and DMA fixes
Date: Mon, 22 Sep 2014 11:50:05 -0700 [thread overview]
Message-ID: <54206F5D.7070000@gmail.com> (raw)
In-Reply-To: <20140922.144618.340968117925494461.davem@davemloft.net>
On 09/22/2014 11:46 AM, David Miller wrote:
> From: Florian Fainelli <f.fainelli@gmail.com>
> Date: Thu, 18 Sep 2014 17:48:15 -0700
>
>> This patch set contains one fix for an accounting problem while reclaiming
>> transmitted buffers having fragments, and the second fix is to make sure
>> that the DMA shutdown is properly controlled.
>
> Florian I am seriesly irritated, are you even build testing these
> changes?
>
> bcmgenet_dma_teardown() is a static function declared far after the
> new call you are adding in patch #2, so now we get:
>
> drivers/net/ethernet/broadcom/genet/bcmgenet.c: In function ‘bcmgenet_fini_dma’:
> drivers/net/ethernet/broadcom/genet/bcmgenet.c:1752:2: error: implicit declaration of function ‘bcmgenet_dma_teardown’ [-Werror=implicit-function-declaration]
> drivers/net/ethernet/broadcom/genet/bcmgenet.c: At top level:
> drivers/net/ethernet/broadcom/genet/bcmgenet.c:2111:12: error: static declaration of ‘bcmgenet_dma_teardown’ follows non-static declaration
> drivers/net/ethernet/broadcom/genet/bcmgenet.c:1752:2: note: previous implicit declaration of ‘bcmgenet_dma_teardown’ was here
>
> I want to make it clear to you that whatever time you think you're
> saving by skipping even the most basic compilation test, goes directly
> to _ME_ and you are therefore having a negative impact on every single
> developer who is also waiting for me to review and integrate their
> networking changes.
>
> Please do not do this any more.
Very sorry about that, v2 is on your way, I will be more careful.
--
Florian
prev parent reply other threads:[~2014-09-22 18:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 0:48 [PATCH net 0/2] net: bcmgenet: TX reclaim and DMA fixes Florian Fainelli
2014-09-19 0:48 ` [PATCH net 1/2] net: bcmgenet: fix TX reclaim accounting for fragments Florian Fainelli
2014-09-19 0:48 ` [PATCH net 2/2] net: bcmgenet: call bcmgenet_dma_teardown in bcmgenet_fini_dma Florian Fainelli
2014-09-22 18:46 ` [PATCH net 0/2] net: bcmgenet: TX reclaim and DMA fixes David Miller
2014-09-22 18:50 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54206F5D.7070000@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.