From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <dslutz@verizon.com>
Subject: Re: [PATCH for-4.5 v6 09/16] tools: Add limited support
 of VMware's hyper-call rpc
Date: Mon, 22 Sep 2014 17:32:44 -0400
Message-ID: <5420957C.9080402@terremark.com>
References: <1411236447-7435-1-git-send-email-dslutz@verizon.com>	
	<1411236447-7435-10-git-send-email-dslutz@verizon.com>
	<1411393957.18331.111.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1411393957.18331.111.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>, Don Slutz <dslutz@verizon.com>
Cc: Tim Deegan <tim@xen.org>, Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>, Jun Nakajima <jun.nakajima@intel.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Eddie Dong <eddie.dong@intel.com>, xen-devel@lists.xen.org, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>, Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
List-Id: xen-devel@lists.xenproject.org


On 09/22/14 09:52, Ian Campbell wrote:
> On Sat, 2014-09-20 at 14:07 -0400, Don Slutz wrote:
>>    This guestinfo support is provided via libxc.  libxl support has
>> not be written.
>>
>> Note: VMware RPC support is only available on HVM domU.
>>
>> This interface is an extension of __HYPERVISOR_HVM_op.  It was
>> picked because xc_get_hvm_param() also uses it and VMware guest
>> info is a lot like a hvm param.
>>
>> The HVMOP_get_vmport_guest_info is used by two libxc functions,
>> xc_get_vmport_guest_info and xc_fetch_all_vmport_guest_info.
>> xc_fetch_all_vmport_guest_info is designed to be used to fetch all
>> currently set guestinfo values.
>>
>> Signed-off-by: Don Slutz <dslutz@verizon.com>
> These look to be correct implementations of accessors for the hypercalls
> as defined, although apart from my query about whether this belongs in
> Xen at all I do have concerns about an hvm param argument struct of >4K.
> AIUI more normal would be to have two GUEST_HANDLE* fields and to copy
> in/out explicitly.

All my tests show this working.  I am not aware of a >4K issue with
a GUEST_HANDLE*.  Is this more a case of the 1st use?

> Ultimately that's up to the hypervisor maintainers though.

Ok.

> Ian.
>