All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zefan Li <lizefan@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>, Kees Cook <keescook@chromium.org>,
	Miao Xie <miaox@cn.fujitsu.com>,
	Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
	LKML <linux-kernel@vger.kernel.org>,
	Cgroups <cgroups@vger.kernel.org>
Subject: [PATCH v3 1/3] sched: fix confusing PFA_NO_NEW_PRIVS constant
Date: Tue, 23 Sep 2014 15:44:19 +0800	[thread overview]
Message-ID: <542124D3.9000007@huawei.com> (raw)

From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>

Commit 1d4457f99928 ("sched: move no_new_privs into new atomic flags")
defined PFA_NO_NEW_PRIVS as hexadecimal value, but it is confusing
because it is used as bit number. Redefine it as decimal bit number.

Note this changes the bit position of PFA_NOW_NEW_PRIVS from 1 to 0.

Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Miao Xie <miaox@cn.fujitsu.com>
Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Acked-by: Kees Cook <keescook@chromium.org>
[ lizf: slightly modified subject and changelog ]
Signed-off-by: Zefan Li <lizefan@huawei.com>
---
 include/linux/sched.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/sched.h b/include/linux/sched.h
index 5c2c885..4557765 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1957,7 +1957,7 @@ static inline void memalloc_noio_restore(unsigned int flags)
 }
 
 /* Per-process atomic flags. */
-#define PFA_NO_NEW_PRIVS 0x00000001	/* May not gain new privileges. */
+#define PFA_NO_NEW_PRIVS 0	/* May not gain new privileges. */
 
 static inline bool task_no_new_privs(struct task_struct *p)
 {
-- 
1.8.0.2

             reply	other threads:[~2014-09-23  7:44 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-23  7:44 Zefan Li [this message]
2014-09-23  7:44 ` [PATCH v3 2/3] sched: add macros to define bitops for task atomic flags Zefan Li
     [not found]   ` <542124FB.4030109-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-09-23 10:01     ` Peter Zijlstra
2014-09-23 10:01       ` Peter Zijlstra
     [not found]       ` <20140923100127.GE3312-IIpfhp3q70z/8w/KjCw3T+5/BudmfyzbbVWyRVo5IupeoWH0uzbU5w@public.gmane.org>
2014-09-23 16:58         ` Kees Cook
2014-09-23 16:58           ` Kees Cook
2014-09-23  7:45 ` [PATCH v3 3/3] cpuset: PF_SPREAD_PAGE and PF_SPREAD_SLAB should be " Zefan Li
2014-09-23 22:10   ` David Rientjes
     [not found]     ` <alpine.DEB.2.02.1409231508590.22630-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2014-09-24  3:15       ` Zefan Li
2014-09-24  3:15         ` Zefan Li
     [not found] ` <542124D3.9000007-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-09-24 13:22   ` [PATCH v3 1/3] sched: fix confusing PFA_NO_NEW_PRIVS constant Tejun Heo
2014-09-24 13:22     ` Tejun Heo
     [not found]     ` <20140924132218.GC16555-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-09-24 13:35       ` Tejun Heo
2014-09-24 13:35         ` Tejun Heo
2014-09-24 14:09         ` Tetsuo Handa
     [not found]           ` <201409242309.HDF95877.OSVFFtQLJMOHOF-JPay3/Yim36HaxMnTkn67Xf5DAMn2ifp@public.gmane.org>
2014-09-24 14:32             ` Tejun Heo
2014-09-24 14:32               ` Tejun Heo
     [not found]         ` <20140924133513.GD16555-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-09-25  1:42           ` Zefan Li
2014-09-25  1:42             ` Zefan Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=542124D3.9000007@huawei.com \
    --to=lizefan@huawei.com \
    --cc=cgroups@vger.kernel.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miaox@cn.fujitsu.com \
    --cc=mingo@kernel.org \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=peterz@infradead.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.