From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <54212C00.2090800@atmel.com> Date: Tue, 23 Sep 2014 10:14:56 +0200 From: Nicolas Ferre MIME-Version: 1.0 To: Boris BREZILLON , "Jean-Christophe Plagniol-Villard" , Alexandre Belloni , Andrew Victor , Alessandro Zummo , , "Samuel Ortiz" , Lee Jones , Johan Hovold CC: Rob Herring , Pawel Moll , "Mark Rutland" , Ian Campbell , Kumar Gala , , , Subject: Re: [PATCH v6 2/9] rtc: at91sam9: use standard readl/writel functions instead of raw versions References: <1411400563-570-1-git-send-email-boris.brezillon@free-electrons.com> <1411400563-570-3-git-send-email-boris.brezillon@free-electrons.com> In-Reply-To: <1411400563-570-3-git-send-email-boris.brezillon@free-electrons.com> Content-Type: text/plain; charset="ISO-8859-1" List-ID: Can be good to know why... here. Otherwise, you can add my: Acked-by: Nicolas Ferre On 22/09/2014 17:42, Boris BREZILLON : > Signed-off-by: Boris BREZILLON > Acked-by: Alexandre Belloni > --- > drivers/rtc/rtc-at91sam9.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/rtc/rtc-at91sam9.c b/drivers/rtc/rtc-at91sam9.c > index 51f0038..74a9ca0 100644 > --- a/drivers/rtc/rtc-at91sam9.c > +++ b/drivers/rtc/rtc-at91sam9.c > @@ -77,14 +77,14 @@ struct sam9_rtc { > }; > > #define rtt_readl(rtc, field) \ > - __raw_readl((rtc)->rtt + AT91_RTT_ ## field) > + readl((rtc)->rtt + AT91_RTT_ ## field) > #define rtt_writel(rtc, field, val) \ > - __raw_writel((val), (rtc)->rtt + AT91_RTT_ ## field) > + writel((val), (rtc)->rtt + AT91_RTT_ ## field) > > #define gpbr_readl(rtc) \ > - __raw_readl((rtc)->gpbr) > + readl((rtc)->gpbr) > #define gpbr_writel(rtc, val) \ > - __raw_writel((val), (rtc)->gpbr) > + writel((val), (rtc)->gpbr) > > /* > * Read current time and date in RTC > -- Nicolas Ferre From mboxrd@z Thu Jan 1 00:00:00 1970 From: nicolas.ferre@atmel.com (Nicolas Ferre) Date: Tue, 23 Sep 2014 10:14:56 +0200 Subject: [PATCH v6 2/9] rtc: at91sam9: use standard readl/writel functions instead of raw versions In-Reply-To: <1411400563-570-3-git-send-email-boris.brezillon@free-electrons.com> References: <1411400563-570-1-git-send-email-boris.brezillon@free-electrons.com> <1411400563-570-3-git-send-email-boris.brezillon@free-electrons.com> Message-ID: <54212C00.2090800@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Can be good to know why... here. Otherwise, you can add my: Acked-by: Nicolas Ferre On 22/09/2014 17:42, Boris BREZILLON : > Signed-off-by: Boris BREZILLON > Acked-by: Alexandre Belloni > --- > drivers/rtc/rtc-at91sam9.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/rtc/rtc-at91sam9.c b/drivers/rtc/rtc-at91sam9.c > index 51f0038..74a9ca0 100644 > --- a/drivers/rtc/rtc-at91sam9.c > +++ b/drivers/rtc/rtc-at91sam9.c > @@ -77,14 +77,14 @@ struct sam9_rtc { > }; > > #define rtt_readl(rtc, field) \ > - __raw_readl((rtc)->rtt + AT91_RTT_ ## field) > + readl((rtc)->rtt + AT91_RTT_ ## field) > #define rtt_writel(rtc, field, val) \ > - __raw_writel((val), (rtc)->rtt + AT91_RTT_ ## field) > + writel((val), (rtc)->rtt + AT91_RTT_ ## field) > > #define gpbr_readl(rtc) \ > - __raw_readl((rtc)->gpbr) > + readl((rtc)->gpbr) > #define gpbr_writel(rtc, val) \ > - __raw_writel((val), (rtc)->gpbr) > + writel((val), (rtc)->gpbr) > > /* > * Read current time and date in RTC > -- Nicolas Ferre From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Ferre Subject: Re: [PATCH v6 2/9] rtc: at91sam9: use standard readl/writel functions instead of raw versions Date: Tue, 23 Sep 2014 10:14:56 +0200 Message-ID: <54212C00.2090800@atmel.com> References: <1411400563-570-1-git-send-email-boris.brezillon@free-electrons.com> <1411400563-570-3-git-send-email-boris.brezillon@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1411400563-570-3-git-send-email-boris.brezillon@free-electrons.com> Sender: linux-kernel-owner@vger.kernel.org To: Boris BREZILLON , Jean-Christophe Plagniol-Villard , Alexandre Belloni , Andrew Victor , Alessandro Zummo , rtc-linux@googlegroups.com, Samuel Ortiz , Lee Jones , Johan Hovold Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org Can be good to know why... here. Otherwise, you can add my: Acked-by: Nicolas Ferre On 22/09/2014 17:42, Boris BREZILLON : > Signed-off-by: Boris BREZILLON > Acked-by: Alexandre Belloni > --- > drivers/rtc/rtc-at91sam9.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/rtc/rtc-at91sam9.c b/drivers/rtc/rtc-at91sam9.c > index 51f0038..74a9ca0 100644 > --- a/drivers/rtc/rtc-at91sam9.c > +++ b/drivers/rtc/rtc-at91sam9.c > @@ -77,14 +77,14 @@ struct sam9_rtc { > }; > > #define rtt_readl(rtc, field) \ > - __raw_readl((rtc)->rtt + AT91_RTT_ ## field) > + readl((rtc)->rtt + AT91_RTT_ ## field) > #define rtt_writel(rtc, field, val) \ > - __raw_writel((val), (rtc)->rtt + AT91_RTT_ ## field) > + writel((val), (rtc)->rtt + AT91_RTT_ ## field) > > #define gpbr_readl(rtc) \ > - __raw_readl((rtc)->gpbr) > + readl((rtc)->gpbr) > #define gpbr_writel(rtc, val) \ > - __raw_writel((val), (rtc)->gpbr) > + writel((val), (rtc)->gpbr) > > /* > * Read current time and date in RTC > -- Nicolas Ferre