From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <54212C2A.8000109@atmel.com> Date: Tue, 23 Sep 2014 10:15:38 +0200 From: Nicolas Ferre MIME-Version: 1.0 To: Boris BREZILLON , "Jean-Christophe Plagniol-Villard" , Alexandre Belloni , Andrew Victor , Alessandro Zummo , , "Samuel Ortiz" , Lee Jones , Johan Hovold CC: Rob Herring , Pawel Moll , "Mark Rutland" , Ian Campbell , Kumar Gala , , , Subject: Re: [PATCH v6 3/9] rtc: at91sam9: replace devm_ioremap by devm_ioremap_resource References: <1411400563-570-1-git-send-email-boris.brezillon@free-electrons.com> <1411400563-570-4-git-send-email-boris.brezillon@free-electrons.com> In-Reply-To: <1411400563-570-4-git-send-email-boris.brezillon@free-electrons.com> Content-Type: text/plain; charset="ISO-8859-1" List-ID: On 22/09/2014 17:42, Boris BREZILLON : > Replace devm_ioremap calls by devm_ioremap_resource which already check > resource consistency (resource != NULL) and print an error in case of > failure. > > Signed-off-by: Boris BREZILLON > Acked-by: Alexandre Belloni Acked-by: Nicolas Ferre > --- > drivers/rtc/rtc-at91sam9.c | 29 ++++++++++------------------- > 1 file changed, 10 insertions(+), 19 deletions(-) > > diff --git a/drivers/rtc/rtc-at91sam9.c b/drivers/rtc/rtc-at91sam9.c > index 74a9ca0..38a2693 100644 > --- a/drivers/rtc/rtc-at91sam9.c > +++ b/drivers/rtc/rtc-at91sam9.c > @@ -306,18 +306,11 @@ static const struct rtc_class_ops at91_rtc_ops = { > */ > static int at91_rtc_probe(struct platform_device *pdev) > { > - struct resource *r, *r_gpbr; > + struct resource *r; > struct sam9_rtc *rtc; > int ret, irq; > u32 mr; > > - r = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - r_gpbr = platform_get_resource(pdev, IORESOURCE_MEM, 1); > - if (!r || !r_gpbr) { > - dev_err(&pdev->dev, "need 2 ressources\n"); > - return -ENODEV; > - } > - > irq = platform_get_irq(pdev, 0); > if (irq < 0) { > dev_err(&pdev->dev, "failed to get interrupt resource\n"); > @@ -335,18 +328,16 @@ static int at91_rtc_probe(struct platform_device *pdev) > device_init_wakeup(&pdev->dev, 1); > > platform_set_drvdata(pdev, rtc); > - rtc->rtt = devm_ioremap(&pdev->dev, r->start, resource_size(r)); > - if (!rtc->rtt) { > - dev_err(&pdev->dev, "failed to map registers, aborting.\n"); > - return -ENOMEM; > - } > > - rtc->gpbr = devm_ioremap(&pdev->dev, r_gpbr->start, > - resource_size(r_gpbr)); > - if (!rtc->gpbr) { > - dev_err(&pdev->dev, "failed to map gpbr registers, aborting.\n"); > - return -ENOMEM; > - } > + r = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + rtc->rtt = devm_ioremap_resource(&pdev->dev, r); > + if (IS_ERR(rtc->rtt)) > + return PTR_ERR(rtc->rtt); > + > + r = platform_get_resource(pdev, IORESOURCE_MEM, 1); > + rtc->gpbr = devm_ioremap_resource(&pdev->dev, r); > + if (IS_ERR(rtc->gpbr)) > + return PTR_ERR(rtc->rtt); > > mr = rtt_readl(rtc, MR); > > -- Nicolas Ferre From mboxrd@z Thu Jan 1 00:00:00 1970 From: nicolas.ferre@atmel.com (Nicolas Ferre) Date: Tue, 23 Sep 2014 10:15:38 +0200 Subject: [PATCH v6 3/9] rtc: at91sam9: replace devm_ioremap by devm_ioremap_resource In-Reply-To: <1411400563-570-4-git-send-email-boris.brezillon@free-electrons.com> References: <1411400563-570-1-git-send-email-boris.brezillon@free-electrons.com> <1411400563-570-4-git-send-email-boris.brezillon@free-electrons.com> Message-ID: <54212C2A.8000109@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 22/09/2014 17:42, Boris BREZILLON : > Replace devm_ioremap calls by devm_ioremap_resource which already check > resource consistency (resource != NULL) and print an error in case of > failure. > > Signed-off-by: Boris BREZILLON > Acked-by: Alexandre Belloni Acked-by: Nicolas Ferre > --- > drivers/rtc/rtc-at91sam9.c | 29 ++++++++++------------------- > 1 file changed, 10 insertions(+), 19 deletions(-) > > diff --git a/drivers/rtc/rtc-at91sam9.c b/drivers/rtc/rtc-at91sam9.c > index 74a9ca0..38a2693 100644 > --- a/drivers/rtc/rtc-at91sam9.c > +++ b/drivers/rtc/rtc-at91sam9.c > @@ -306,18 +306,11 @@ static const struct rtc_class_ops at91_rtc_ops = { > */ > static int at91_rtc_probe(struct platform_device *pdev) > { > - struct resource *r, *r_gpbr; > + struct resource *r; > struct sam9_rtc *rtc; > int ret, irq; > u32 mr; > > - r = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - r_gpbr = platform_get_resource(pdev, IORESOURCE_MEM, 1); > - if (!r || !r_gpbr) { > - dev_err(&pdev->dev, "need 2 ressources\n"); > - return -ENODEV; > - } > - > irq = platform_get_irq(pdev, 0); > if (irq < 0) { > dev_err(&pdev->dev, "failed to get interrupt resource\n"); > @@ -335,18 +328,16 @@ static int at91_rtc_probe(struct platform_device *pdev) > device_init_wakeup(&pdev->dev, 1); > > platform_set_drvdata(pdev, rtc); > - rtc->rtt = devm_ioremap(&pdev->dev, r->start, resource_size(r)); > - if (!rtc->rtt) { > - dev_err(&pdev->dev, "failed to map registers, aborting.\n"); > - return -ENOMEM; > - } > > - rtc->gpbr = devm_ioremap(&pdev->dev, r_gpbr->start, > - resource_size(r_gpbr)); > - if (!rtc->gpbr) { > - dev_err(&pdev->dev, "failed to map gpbr registers, aborting.\n"); > - return -ENOMEM; > - } > + r = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + rtc->rtt = devm_ioremap_resource(&pdev->dev, r); > + if (IS_ERR(rtc->rtt)) > + return PTR_ERR(rtc->rtt); > + > + r = platform_get_resource(pdev, IORESOURCE_MEM, 1); > + rtc->gpbr = devm_ioremap_resource(&pdev->dev, r); > + if (IS_ERR(rtc->gpbr)) > + return PTR_ERR(rtc->rtt); > > mr = rtt_readl(rtc, MR); > > -- Nicolas Ferre From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Ferre Subject: Re: [PATCH v6 3/9] rtc: at91sam9: replace devm_ioremap by devm_ioremap_resource Date: Tue, 23 Sep 2014 10:15:38 +0200 Message-ID: <54212C2A.8000109@atmel.com> References: <1411400563-570-1-git-send-email-boris.brezillon@free-electrons.com> <1411400563-570-4-git-send-email-boris.brezillon@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1411400563-570-4-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Boris BREZILLON , Jean-Christophe Plagniol-Villard , Alexandre Belloni , Andrew Victor , Alessandro Zummo , rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Samuel Ortiz , Lee Jones , Johan Hovold Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 22/09/2014 17:42, Boris BREZILLON : > Replace devm_ioremap calls by devm_ioremap_resource which already check > resource consistency (resource != NULL) and print an error in case of > failure. > > Signed-off-by: Boris BREZILLON > Acked-by: Alexandre Belloni Acked-by: Nicolas Ferre > --- > drivers/rtc/rtc-at91sam9.c | 29 ++++++++++------------------- > 1 file changed, 10 insertions(+), 19 deletions(-) > > diff --git a/drivers/rtc/rtc-at91sam9.c b/drivers/rtc/rtc-at91sam9.c > index 74a9ca0..38a2693 100644 > --- a/drivers/rtc/rtc-at91sam9.c > +++ b/drivers/rtc/rtc-at91sam9.c > @@ -306,18 +306,11 @@ static const struct rtc_class_ops at91_rtc_ops = { > */ > static int at91_rtc_probe(struct platform_device *pdev) > { > - struct resource *r, *r_gpbr; > + struct resource *r; > struct sam9_rtc *rtc; > int ret, irq; > u32 mr; > > - r = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - r_gpbr = platform_get_resource(pdev, IORESOURCE_MEM, 1); > - if (!r || !r_gpbr) { > - dev_err(&pdev->dev, "need 2 ressources\n"); > - return -ENODEV; > - } > - > irq = platform_get_irq(pdev, 0); > if (irq < 0) { > dev_err(&pdev->dev, "failed to get interrupt resource\n"); > @@ -335,18 +328,16 @@ static int at91_rtc_probe(struct platform_device *pdev) > device_init_wakeup(&pdev->dev, 1); > > platform_set_drvdata(pdev, rtc); > - rtc->rtt = devm_ioremap(&pdev->dev, r->start, resource_size(r)); > - if (!rtc->rtt) { > - dev_err(&pdev->dev, "failed to map registers, aborting.\n"); > - return -ENOMEM; > - } > > - rtc->gpbr = devm_ioremap(&pdev->dev, r_gpbr->start, > - resource_size(r_gpbr)); > - if (!rtc->gpbr) { > - dev_err(&pdev->dev, "failed to map gpbr registers, aborting.\n"); > - return -ENOMEM; > - } > + r = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + rtc->rtt = devm_ioremap_resource(&pdev->dev, r); > + if (IS_ERR(rtc->rtt)) > + return PTR_ERR(rtc->rtt); > + > + r = platform_get_resource(pdev, IORESOURCE_MEM, 1); > + rtc->gpbr = devm_ioremap_resource(&pdev->dev, r); > + if (IS_ERR(rtc->gpbr)) > + return PTR_ERR(rtc->rtt); > > mr = rtt_readl(rtc, MR); > > -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html