From: pbonzini@redhat.com (Paolo Bonzini)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] arm/arm64: KVM: Fix unaligned access bug on gicv2 access
Date: Tue, 23 Sep 2014 10:36:30 +0200 [thread overview]
Message-ID: <5421310E.9020902@redhat.com> (raw)
In-Reply-To: <20140922220710.GA24499@arm.com>
Il 23/09/2014 00:07, Will Deacon ha scritto:
>> > {
>> > if (!(lr_desc.state & LR_STATE_MASK))
>> > - set_bit(lr, (unsigned long *)vcpu->arch.vgic_cpu.vgic_v2.vgic_elrsr);
>> > + __set_bit(lr, (unsigned long *)vcpu->arch.vgic_cpu.vgic_v2.vgic_elrsr);
>> > }
> Does this work for big-endian arm64 machines? Surely the bug is due to
> casting a u32 * to an unsigned long *, and not specifically related to
> atomics (which is where it happened to explode)?
I agree, this doesn't seem to be the right fix.
Paolo
next prev parent reply other threads:[~2014-09-23 8:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 21:12 [GIT PULL] Last-minute fix for kvm/arm64 Christoffer Dall
2014-09-22 21:12 ` [GIT PULL] arm/arm64: KVM: Fix unaligned access bug on gicv2 access Christoffer Dall
2014-09-22 22:07 ` Will Deacon
2014-09-23 8:36 ` Paolo Bonzini [this message]
2014-09-23 11:14 ` Christoffer Dall
2014-09-23 11:50 ` Paolo Bonzini
2014-09-23 12:44 ` Andre Przywara
2014-09-23 12:48 ` Paolo Bonzini
2014-09-23 13:52 ` Christoffer Dall
2014-09-23 13:52 ` Paolo Bonzini
2014-09-23 14:07 ` Christoffer Dall
2014-09-23 14:01 ` Peter Maydell
2014-09-23 14:03 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5421310E.9020902@redhat.com \
--to=pbonzini@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.