From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanimir Varbanov Subject: Re: [PATCH] rtc: pm8xxx: rework to support pm8941 rtc Date: Tue, 23 Sep 2014 12:02:00 +0300 Message-ID: <54213708.7050605@mm-sol.com> References: <1410515044-31689-1-git-send-email-svarbanov@mm-sol.com> <20140919160347.eaa72f4b715338e4210790df@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140919160347.eaa72f4b715338e4210790df@linux-foundation.org> Sender: linux-kernel-owner@vger.kernel.org To: Andrew Morton Cc: Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Stephen Boyd , Josh Cartwright List-Id: linux-arm-msm@vger.kernel.org On 09/20/2014 02:03 AM, Andrew Morton wrote: > On Fri, 12 Sep 2014 12:44:04 +0300 Stanimir Varbanov wrote: > >> Adds support for RTC device inside PM8941 PMIC. The RTC >> in this PMIC have two register spaces. Thus the rtc-pm8xxx >> is slightly reworked to reflect these differences. >> >> The register set for different PMIC chips are selected >> on DT compatible string base. > > checkpatch (which you obviously didn't use!) says > > WARNING: DT compatible string "qcom,pm8941-rtc" appears un-documented -- check ./Documentation/devicetree/bindings/ > #414: FILE: drivers/rtc/rtc-pm8xxx.c:435: > + { .compatible = "qcom,pm8941-rtc", .data = &pm8941_regs }, Ahh, sorry for inconvenience I forgot to run checkpatch over this patch. I will send follow-up patch which will add the compatible string in the pm8xxx binding document. -- regards, Stan