All of lore.kernel.org
 help / color / mirror / Atom feed
From: Antti Palosaari <crope@iki.fi>
To: Bimow Chen <Bimow.Chen@ite.com.tw>, linux-media@vger.kernel.org
Subject: Re: [1/2] af9033: fix it9135 strength value not correct issue
Date: Tue, 23 Sep 2014 13:54:16 +0300	[thread overview]
Message-ID: <54215158.6000607@iki.fi> (raw)
In-Reply-To: <1411465442.1919.6.camel@ite-desktop>

Moikka Bimow!
Thank you for improving these statistics.

I did a quite much changes, basically re-implemented all the 
af9033/it9133 demod statistics, already. I am not sure if you saw those, 
but please look that tree first:
http://git.linuxtv.org/cgit.cgi/media_tree.git/log/?h=devel-3.17-rc6

If you want to some more statistics changes, please to top of that tree. 
We currently have 2 APIs for statistics. Old DVBv3 which uses frontend 
callbacks: read_snr, read_signal_strength, read_ber and read_ucblocks. 
New DVBv5 API uses different commands, which reads values from frontend 
cache.

Driver implements now DVBv5 statistics. Old DVBv3 statistics are there 
still, but those are just wrappers to return DVBv5 statistics.

You would like to examine these patches first:

$ git log media/devel-3.17-rc6 --oneline|grep af9033
2db4d17 [media] af9033: init DVBv5 statistics
ef2fb46 [media] af9033: remove all DVBv3 stat calculation logic
e53c474 [media] af9033: wrap DVBv3 BER to DVBv5 BER
1d0ceae [media] af9033: wrap DVBv3 UCB to DVBv5 UCB stats
6bb096c [media] af9033: implement DVBv5 post-Viterbi BER
204f431 [media] af9033: implement DVBv5 stat block counters
6b45778 [media] af9033: wrap DVBv3 read SNR to DVBv5 CNR
3e41313 [media] af9033: implement DVBv5 statistics for CNR
83f1161 [media] af9033: implement DVBv5 statistics for signal strength


I am happy to took improvements which are done top of these.

regards
Antti

-- 
http://palosaari.fi/

      reply	other threads:[~2014-09-23 10:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-23  9:44 [1/2] af9033: fix it9135 strength value not correct issue Bimow Chen
2014-09-23 10:54 ` Antti Palosaari [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54215158.6000607@iki.fi \
    --to=crope@iki.fi \
    --cc=Bimow.Chen@ite.com.tw \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.