diff for duplicates of <542195B0.6080706@gmail.com> diff --git a/a/1.txt b/N1/1.txt index ff20da9..6adbeb5 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -4,20 +4,20 @@ On 09/23/2014 04:37 PM, Arnd Bergmann wrote: >> So I had a look on other Ethernet bindings. Would you agree with >> something like the following? >> ->> eth0: ethernet at f7b90000 { +>> eth0: ethernet@f7b90000 { >> ... >> #address-cells = <1>; >> #size-cells = <0>; >> phy-handle = <ðphy0>; >> ->> ethphy0: ethernet-phy at 0 { +>> ethphy0: ethernet-phy@0 { >> reg = <0>; >> }; >> }; > > Yes, that looks good. -nit: ethernet-phy at 0 should not be part of the ethernet controller +nit: ethernet-phy@0 should not be part of the ethernet controller but either part of a separate mdio-ctrl node or a separate node itself. AFAIKS, Berlin SoCs have internal PHYs, i.e. no MII/MDIO-pins exposed @@ -26,12 +26,12 @@ ethernet IP to a PHY capable of HDMI Ethernet Channel (HEC). So for BG2CD this has to look something like: -eth0: ethernet at f7b90000 { +eth0: ethernet@f7b90000 { ... phy-handle = <&hec>; }; -cec: cec at f7f00baa { +cec: cec@f7f00baa { compatible = "marvell,berlin-cec"; reg = <0xf7f00baa 0x1234>; @@ -44,7 +44,7 @@ cec: cec at f7f00baa { For reference, this is what we have for MVEBU SoCs with multiple ports per controller: -eth: ethernet-ctrl at 72000 { +eth: ethernet-ctrl@72000 { compatible = "marvell,orion-eth"; #address-cells = <1>; #size-cells = <0>; @@ -53,7 +53,7 @@ eth: ethernet-ctrl at 72000 { marvell,tx-checksum-limit = <1600>; status = "disabled"; - ethernet-port at 0 { + ethernet-port@0 { compatible = "marvell,orion-eth-port"; reg = <0>; interrupts = <29>; @@ -63,7 +63,7 @@ eth: ethernet-ctrl at 72000 { }; }; -mdio: mdio-bus at 72004 { +mdio: mdio-bus@72004 { compatible = "marvell,orion-mdio"; #address-cells = <1>; #size-cells = <0>; diff --git a/a/content_digest b/N1/content_digest index e09e707..f70ee1c 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,10 +2,19 @@ "ref\020140923140113.GC18924@kwain\0" "ref\020140923142922.GE18924@kwain\0" "ref\04014272.rJbSfrLcuB@wuerfel\0" - "From\0sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)\0" - "Subject\0[PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller\0" + "From\0Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>\0" + "Subject\0Re: [PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller\0" "Date\0Tue, 23 Sep 2014 17:45:52 +0200\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Arnd Bergmann <arnd@arndb.de>" + " linux-arm-kernel@lists.infradead.org\0" + "Cc\0Antoine Tenart <antoine.tenart@free-electrons.com>" + thomas.petazzoni@free-electrons.com + zmxu@marvell.com + devicetree@vger.kernel.org + netdev@vger.kernel.org + linux-kernel@vger.kernel.org + alexandre.belloni@free-electrons.com + " jszhang@marvell.com\0" "\00:1\0" "b\0" "On 09/23/2014 04:37 PM, Arnd Bergmann wrote:\n" @@ -14,20 +23,20 @@ ">> So I had a look on other Ethernet bindings. Would you agree with\n" ">> something like the following?\n" ">>\n" - ">> eth0: ethernet at f7b90000 {\n" + ">> eth0: ethernet@f7b90000 {\n" ">> ...\n" ">> #address-cells = <1>;\n" ">> #size-cells = <0>;\n" ">> phy-handle = <ðphy0>;\n" ">>\n" - ">> ethphy0: ethernet-phy at 0 {\n" + ">> ethphy0: ethernet-phy@0 {\n" ">> reg = <0>;\n" ">> };\n" ">> };\n" ">\n" "> Yes, that looks good.\n" "\n" - "nit: ethernet-phy at 0 should not be part of the ethernet controller\n" + "nit: ethernet-phy@0 should not be part of the ethernet controller\n" "but either part of a separate mdio-ctrl node or a separate node itself.\n" "\n" "AFAIKS, Berlin SoCs have internal PHYs, i.e. no MII/MDIO-pins exposed\n" @@ -36,12 +45,12 @@ "\n" "So for BG2CD this has to look something like:\n" "\n" - "eth0: ethernet at f7b90000 {\n" + "eth0: ethernet@f7b90000 {\n" "\t...\n" "\tphy-handle = <&hec>;\n" "};\n" "\n" - "cec: cec at f7f00baa {\n" + "cec: cec@f7f00baa {\n" "\tcompatible = \"marvell,berlin-cec\";\n" "\treg = <0xf7f00baa 0x1234>;\n" "\n" @@ -54,7 +63,7 @@ "For reference, this is what we have for MVEBU SoCs with multiple ports\n" "per controller:\n" "\n" - "eth: ethernet-ctrl at 72000 {\n" + "eth: ethernet-ctrl@72000 {\n" "\tcompatible = \"marvell,orion-eth\";\n" "\t#address-cells = <1>;\n" "\t#size-cells = <0>;\n" @@ -63,7 +72,7 @@ "\tmarvell,tx-checksum-limit = <1600>;\n" "\tstatus = \"disabled\";\n" "\n" - "\tethernet-port at 0 {\n" + "\tethernet-port@0 {\n" "\t\tcompatible = \"marvell,orion-eth-port\";\n" "\t\treg = <0>;\n" "\t\tinterrupts = <29>;\n" @@ -73,7 +82,7 @@ "\t};\n" "};\n" "\n" - "mdio: mdio-bus at 72004 {\n" + "mdio: mdio-bus@72004 {\n" "\tcompatible = \"marvell,orion-mdio\";\n" "\t#address-cells = <1>;\n" "\t#size-cells = <0>;\n" @@ -88,4 +97,4 @@ "\n" Sebastian -99ffc4307e7765155f39fb6c5f223717591f97a115995d5b2131a3693507109e +ea80afad70079bdc06a094bebf5a8ef36537378d47a565a8296364acc0233372
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.