From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kukjin Kim Subject: Re: [PATCH 0/3 v3] Fix Exynos USB on kernels with USB Gadget support Date: Wed, 24 Sep 2014 01:04:04 +0900 Message-ID: <542199F4.3090601@samsung.com> References: <1410778354-31210-1-git-send-email-sjoerd.simons@collabora.co.uk> <1411112614.29071.1.camel@collabora.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1411112614.29071.1.camel@collabora.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Sjoerd Simons Cc: linux-samsung-soc@vger.kernel.org, Kukjin Kim , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org T24gMDkvMTkvMTQgMTY6NDMsIFNqb2VyZCBTaW1vbnMgd3JvdGU6Cj4gSGV5IEt1a2ppbiwKPgpI aSwKClNvcnJ5IGZvciBsYXRlIHJlc3BvbnNlLi4uCgo+IEl0J3MgYmVlbiBhbG1vc3QgYSBtb250 aCBzaW5jZSBJIHBvc3RlZCB0aGUgZmlyc3QgaXRlcmF0aW9uIG9mIHRoaXMKPiBwYXRjaHNldCBv biB0aGUgbGlzdCwgd2l0aCBvbmx5IHRyaXZpYWwgY29zbWV0aWMgY2hhbmdlcyBhbmQgYW4gYWRk aXRpb24KPiBvZiBhIHNpbWlsYXIgZml4IGZvciBBcm5kYWxlIE9jdGEgYm9hcmRzLiBEbyB5b3Ug ZmVlbCBpdCBuZWVkcyBtb3JlCj4gcmV2aWV3IGZyb20gc3BlY2lmaWMgZm9sa3MgYmVmb3JlIHB1 bGxpbmcgaXQgaW4gb3IgPwo+Cj4gU2VlbXMgYSBiaXQgb2YgYSBzaGFtZSBpZiB0aGlzIHdvdWxk IGZhaWwgdG8gbWFrZSBpdCBmb3IgMy4xOCAob25lIGNvdWxkCj4gZXZlbiBhcmd1ZSB0aGUgZHQg cGF0Y2hlcyBhcmUgMy4xNyBSQyBtYXRlcmlhbCEpIGFzIGl0IGZpeGVzIFVTQgo+IGZ1bmN0aW9u YWxpdHkgYmVpbmcgYnJva2VuIGRlcGVuZGluZyBvbiB0aGUga2VybmVsIGNvbmZpZ3VyYXRpb24g dXNlZC4KPgo+Cj4gT24gTW9uLCAyMDE0LTA5LTE1IGF0IDEyOjUyICswMjAwLCBTam9lcmQgU2lt b25zIHdyb3RlOgo+PiBXaGVuIGJ1aWxkaW5nIGEga2VybmVsIHdpdGggc3VwcG9ydCBmb3IgYm90 aCBVU0IgaG9zdCBhbmQgVVNCIEdhZGdldCBzdXBwb3J0IG9uCj4+IHRoZSBkd2MzIGNvbnRyb2xs ZXIgb24gdGhlIEV4eW5vczUgc29jIHdpbGwgZ28gaW50byBVU0IgT1RHIG1vZGUgdW5sZXNzCj4+ IG90aGVyd2lzZSBzcGVjaWZpZWQgaW4gdGhlIGR0Yiwgd2hpY2ggaXMgdW5oZWxwZnVsIGZvciBi b2FyZHMgaG9va2VkIHVwIHRvIHJ1bgo+PiBhcyBVU0IgaG9zdC4KPj4KPj4gRmlyc3QgcGF0Y2gg aW4gdGhpcyBzZXQgZXhwbGljaXRlbHkgc2V0IHRoZSBkdWFsLXJvbGUgbW9kZSBmb3IgdGhlIGR3 YzMKPj4gY29udHJvbGxlciBvbiBQZWFjaCBwaSBhbmQgUGVhY2ggcGl0IGJvYXJkcyB0byBob3N0 IG1vZGUuIFNlY29uZCBwYXRjaCBhZGRzCj4+IHNpbWlsYXIgdXBkYXRlcyBmb3IgQXJuZGFsZSBP Y3RhIGFzIHJlcG9ydGVkIGJ5IEFuZHJlYXMgRsOkcmJlci4gTGFzdCBwYXRjaAo+PiBlbmFibGVz IGdhZGdldCBtb2RlIGluIHRoZSBkZWZhdWx0IGV4eW5vcyBjb25maWcgdG8gbW9yZSBlYXNpbHkg Y2F0Y2gvdHJpZ2dlcgo+PiBpc3N1ZXMgbGlrZSB0aGVzZS4KPj4KPj4gSSBzdXNwZWN0IHRoZSBT YW1zdW5nIFNNREs1NDIwIERUUyBtaWdodCBuZWVkIHNpbWlsYXIgY2hhbmdlcywgc28gaXQgd291 bGQgYmUKPj4gZ3JlYXQgaWYgdXNlcnMgb2YgdGhvc2UgYm9hcmQgY291bGQgdmVyaWZ5IHRoaXMu Cj4+Cj4+IENoYW5nZXMgaW4gdjI6IGFscGhhYmV0aWNhbGx5IHNvcnQgdGhlIGR0cyBlbnRyaWVz Cj4+IENoYW5nZXMgaW4gdjM6IEFkZCBEVFMgdXBkYXRlcyBmb3IgYXJuZGFsZSBvY3RhCj4+Cj4+ IFNqb2VyZCBTaW1vbnMgKDMpOgo+PiAgICBBUk06IGR0czogZXh5bm9zOiBFeHBsaWNpdGx5IHNl dCBkcl9tb2RlIG9uIHBlYWNoLXBpdCBhbmQgcGVhY2gtcGkKPj4gICAgQVJNOiBkdHM6IGV4eW5v czogRXhwbGljaXRseSBzZXQgZHJfbW9kZSBvbiBhcm5kYWxlLW9jdGEKPj4gICAgQVJNOiBleHlu b3NfZGVmY29uZmlnOiBlbmFibGUgVVNCIGdhZGdldCBzdXBwb3J0Cj4+Cj4+ICAgYXJjaC9hcm0v Ym9vdC9kdHMvZXh5bm9zNTQyMC1hcm5kYWxlLW9jdGEuZHRzIHwgNCArKysrCj4+ICAgYXJjaC9h cm0vYm9vdC9kdHMvZXh5bm9zNTQyMC1wZWFjaC1waXQuZHRzICAgIHwgOCArKysrKysrKwo+PiAg IGFyY2gvYXJtL2Jvb3QvZHRzL2V4eW5vczU0MjAuZHRzaSAgICAgICAgICAgICB8IDQgKystLQo+ PiAgIGFyY2gvYXJtL2Jvb3QvZHRzL2V4eW5vczU4MDAtcGVhY2gtcGkuZHRzICAgICB8IDggKysr KysrKysKPj4gICBhcmNoL2FybS9jb25maWdzL2V4eW5vc19kZWZjb25maWcgICAgICAgICAgICAg fCAxICsKPj4gICA1IGZpbGVzIGNoYW5nZWQsIDIzIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25z KC0pCj4+CkkgaGF2ZSBubyBvYmplY3Rpb24gb24gdGhpcyBzZXJpZXMgYnV0IG5lZWRzIHRvIGJl IHJlYmFzZWQgb24gbXkgdHJlZSwgCmNhbiB5b3UgcGxlYXNlIHJlc3BpbiBvbiB0b3Agb2YgbXkg dHJlZT8KClRoYW5rcywKS3VramluCi0tIApUaGFua3MuCgpCZXN0IHJlZ2FyZHMsCktnZW5lLgot LQpLdWtqaW4gS2ltIDxrZ2VuZS5raW1Ac2Ftc3VuZy5jb20+LCBTZW5pb3IgRW5naW5lZXIsClNX IFNvbHV0aW9uIERldmVsb3BtZW50IFRlYW0sIFNhbXN1bmcgRWxlY3Ryb25pY3MgQ28uLCBMdGQu CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1h cm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5v cmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0t a2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: kgene.kim@samsung.com (Kukjin Kim) Date: Wed, 24 Sep 2014 01:04:04 +0900 Subject: [PATCH 0/3 v3] Fix Exynos USB on kernels with USB Gadget support In-Reply-To: <1411112614.29071.1.camel@collabora.co.uk> References: <1410778354-31210-1-git-send-email-sjoerd.simons@collabora.co.uk> <1411112614.29071.1.camel@collabora.co.uk> Message-ID: <542199F4.3090601@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 09/19/14 16:43, Sjoerd Simons wrote: > Hey Kukjin, > Hi, Sorry for late response... > It's been almost a month since I posted the first iteration of this > patchset on the list, with only trivial cosmetic changes and an addition > of a similar fix for Arndale Octa boards. Do you feel it needs more > review from specific folks before pulling it in or ? > > Seems a bit of a shame if this would fail to make it for 3.18 (one could > even argue the dt patches are 3.17 RC material!) as it fixes USB > functionality being broken depending on the kernel configuration used. > > > On Mon, 2014-09-15 at 12:52 +0200, Sjoerd Simons wrote: >> When building a kernel with support for both USB host and USB Gadget support on >> the dwc3 controller on the Exynos5 soc will go into USB OTG mode unless >> otherwise specified in the dtb, which is unhelpful for boards hooked up to run >> as USB host. >> >> First patch in this set explicitely set the dual-role mode for the dwc3 >> controller on Peach pi and Peach pit boards to host mode. Second patch adds >> similar updates for Arndale Octa as reported by Andreas F?rber. Last patch >> enables gadget mode in the default exynos config to more easily catch/trigger >> issues like these. >> >> I suspect the Samsung SMDK5420 DTS might need similar changes, so it would be >> great if users of those board could verify this. >> >> Changes in v2: alphabetically sort the dts entries >> Changes in v3: Add DTS updates for arndale octa >> >> Sjoerd Simons (3): >> ARM: dts: exynos: Explicitly set dr_mode on peach-pit and peach-pi >> ARM: dts: exynos: Explicitly set dr_mode on arndale-octa >> ARM: exynos_defconfig: enable USB gadget support >> >> arch/arm/boot/dts/exynos5420-arndale-octa.dts | 4 ++++ >> arch/arm/boot/dts/exynos5420-peach-pit.dts | 8 ++++++++ >> arch/arm/boot/dts/exynos5420.dtsi | 4 ++-- >> arch/arm/boot/dts/exynos5800-peach-pi.dts | 8 ++++++++ >> arch/arm/configs/exynos_defconfig | 1 + >> 5 files changed, 23 insertions(+), 2 deletions(-) >> I have no objection on this series but needs to be rebased on my tree, can you please respin on top of my tree? Thanks, Kukjin -- Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.