From: Michal Marek <mmarek@suse.cz>
To: David Miller <davem@davemloft.net>
Cc: sfr@canb.auug.org.au, rdunlap@infradead.org,
netdev@vger.kernel.org, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
linux-mips@linux-mips.org
Subject: Re: [PATCH 1/5] mips: Set CONFIG_NET=y in defconfigs
Date: Tue, 23 Sep 2014 18:06:04 +0200 [thread overview]
Message-ID: <54219A6C.7000407@suse.cz> (raw)
In-Reply-To: <20140923.120237.1788295912902036193.davem@davemloft.net>
On 2014-09-23 18:02, David Miller wrote:
> From: Michal Marek <mmarek@suse.cz>
> Date: Tue, 23 Sep 2014 17:44:00 +0200
>
>> Commit 5d6be6a5 ("scsi_netlink : Make SCSI_NETLINK dependent on NET
>> instead of selecting NET") removed what happened to be the only instance
>> of 'select NET'. Defconfigs that were relying on the select now lack
>> networking support.
>>
>> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>> Cc: linux-mips@linux-mips.org
>> Signed-off-by: Michal Marek <mmarek@suse.cz>
>
> On the contrary, since NET was being selected for them indirectly
> previously, weren't they depending instead upon NET being enabled?
>
> Likewise for SCSI_NETLINK, SCSI_FC_ATTRS, and whatever was triggering
> the select upon them?
They have SCSI_FC_ATTRS=y/m and were relying on the select statements
turning this into SCSI_NETLINK=y and CONFIG_NET=y.
Michal
next prev parent reply other threads:[~2014-09-23 16:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 0:32 linux-next: build warning after merge of the net tree Stephen Rothwell
2014-09-18 0:32 ` Stephen Rothwell
2014-09-18 0:35 ` Randy Dunlap
2014-09-23 14:59 ` Michal Marek
2014-09-23 15:44 ` [PATCH 1/5] mips: Set CONFIG_NET=y in defconfigs Michal Marek
2014-09-23 15:44 ` [PATCH 2/5] parisc: " Michal Marek
2014-09-23 15:44 ` [PATCH 3/5] powerpc: " Michal Marek
2014-09-23 15:44 ` Michal Marek
2014-09-23 15:44 ` Michal Marek
2014-09-23 15:44 ` [PATCH 4/5] sh: " Michal Marek
2014-09-23 15:44 ` Michal Marek
2014-09-23 15:44 ` [PATCH 5/5] sparc: " Michal Marek
2014-09-23 15:44 ` Michal Marek
2014-09-23 16:02 ` [PATCH 1/5] mips: " David Miller
2014-09-23 16:06 ` Michal Marek [this message]
2014-09-23 21:23 ` linux-next: build warning after merge of the net tree Stephen Rothwell
2014-09-24 0:36 ` Stephen Rothwell
2014-09-24 1:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54219A6C.7000407@suse.cz \
--to=mmarek@suse.cz \
--cc=davem@davemloft.net \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.