All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nikolay Dimitrov <picmaster@mail.bg>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V4] ARM: mx6: Add support for Kosagi Novena
Date: Wed, 24 Sep 2014 02:57:50 +0300	[thread overview]
Message-ID: <542208FE.2060802@mail.bg> (raw)
In-Reply-To: <1411467483-5766-1-git-send-email-marex@denx.de>

Hi Marek,

Some comments about SPI:

On 09/23/2014 01:18 PM, Marek Vasut wrote:
> +/*
> + * SPI
> + */
> +#ifdef CONFIG_MXC_SPI
> +static iomux_v3_cfg_t ecspi1_pads[] = {
> +	/* SS1 */
> +	MX6_PAD_EIM_D19__GPIO3_IO19   | MUX_PAD_CTRL(SPI_PAD_CTRL),
> +	MX6_PAD_EIM_D17__ECSPI1_MISO | MUX_PAD_CTRL(SPI_PAD_CTRL),
> +	MX6_PAD_EIM_D18__ECSPI1_MOSI | MUX_PAD_CTRL(SPI_PAD_CTRL),
> +	MX6_PAD_EIM_D16__ECSPI1_SCLK | MUX_PAD_CTRL(SPI_PAD_CTRL),
> +};
> +
> +static void novena_spl_setup_iomux_spi(void)
> +{
> +	imx_iomux_v3_setup_multiple_pads(ecspi1_pads, ARRAY_SIZE(ecspi1_pads));
> +	gpio_direction_output(CONFIG_SF_DEFAULT_CS, 1);
> +}
> +#else
> +static void novena_spl_setup_iomux_spi(void) {}
> +#endif

I checked the schematic and didn't saw any usage of ECSPI1. In addition, 
these pads (EIM D16/17/18/19) are used by other interfaces. Can you 
please also double-check this?

Kind regards,
Nikolay

  reply	other threads:[~2014-09-23 23:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-23 10:18 [U-Boot] [PATCH V4] ARM: mx6: Add support for Kosagi Novena Marek Vasut
2014-09-23 23:57 ` Nikolay Dimitrov [this message]
2014-09-24  9:37   ` Marek Vasut
2014-09-24 11:03     ` Nikolay Dimitrov
2014-09-24 11:15       ` Marek Vasut
2014-09-24  2:46 ` Nikolay Dimitrov
2014-09-24  9:40   ` Marek Vasut
2014-09-27 16:46     ` Sean Cross
2014-09-27 20:29       ` Marek Vasut
2014-10-06 15:35     ` Sean Cross
2014-10-06 15:57       ` Marek Vasut
2014-10-06 12:50   ` Nikolay Dimitrov
2014-10-06 14:00     ` Marek Vasut
2014-10-09  0:50       ` Nikolay Dimitrov
2014-10-09  0:54         ` Marek Vasut
2014-09-28  4:44 ` Nikolay Dimitrov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=542208FE.2060802@mail.bg \
    --to=picmaster@mail.bg \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.