From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48172)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1XWacr-00027x-Hx
	for qemu-devel@nongnu.org; Tue, 23 Sep 2014 20:40:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1XWack-0006is-Vo
	for qemu-devel@nongnu.org; Tue, 23 Sep 2014 20:40:09 -0400
Received: from szxga02-in.huawei.com ([119.145.14.65]:59572)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1XWack-0006aM-DY
	for qemu-devel@nongnu.org; Tue, 23 Sep 2014 20:40:02 -0400
Message-ID: <542212C1.9050908@huawei.com>
Date: Wed, 24 Sep 2014 08:39:29 +0800
From: zhanghailiang <zhang.zhanghailiang@huawei.com>
MIME-Version: 1.0
References: <1411108984-4380-1-git-send-email-zhang.zhanghailiang@huawei.com>
In-Reply-To: <1411108984-4380-1-git-send-email-zhang.zhanghailiang@huawei.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v6 0/2] dump: let dump_error return error
	reason to caller
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: luonengjun@huawei.com, peter.huangpeng@huawei.com, armbru@redhat.com, lcapitulino@redhat.com, lersek@redhat.com

Hi,

  Ping...

Thanks,
zhanghailiang

On 2014/9/19 14:43, zhanghailiang wrote:
> Hi,
>
> In original code, Function dump_error ignores its second parameter which contains
> error reason, it is better to return the error message to the caller.
>
> Here we use error_setg to return the error info to caller.
> And at the same time, we turn functions like write_elf64_note() to void,
> Because functions shouldn't return an error code _and_ an Error object.
> After this modification the code will be more clean.
>
> v5 -> v6
> - Don't check *errp directly, if errp is NULL, there will be an error,
>    Instead, check a local variable *local_err (Markus Armbruster)
> v4 -> v5:
> - Turn functions like write_elf64_note() to void (Luiz Capitulino)
> v3 -> v4:
> - Adjust the errp argument to the end
> - Remove trailing '.' in error messages
> v2 -> v3:
> - Drop the '\n' in the message when call dump_error(Eric Blake)
> v1 -> v2:
> - Return the error reason to the caller (Luiz Capitulino)
>
> zhanghailiang (2):
>    dump: let dump_error return error info to caller
>    dump: Don't return error code when return an Error object
>
>   dump.c | 382 +++++++++++++++++++++++++++++++----------------------------------
>   1 file changed, 182 insertions(+), 200 deletions(-)
>