From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757285AbaIXBQz (ORCPT ); Tue, 23 Sep 2014 21:16:55 -0400 Received: from mail9.hitachi.co.jp ([133.145.228.44]:33231 "EHLO mail9.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757267AbaIXBQx (ORCPT ); Tue, 23 Sep 2014 21:16:53 -0400 Message-ID: <54221B7D.3010104@hitachi.com> Date: Wed, 24 Sep 2014 10:16:45 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Steven Rostedt Cc: Shuah Khan , Tom Zanussi , Oleg Nesterov , Namhyung Kim , Fengguang Wu , Ingo Molnar , Shuah Khan , Linux Kernel Mailing List Subject: Re: [PATCH v5 1/4] ftracetest: Initial commit for ftracetest References: <20140922234248.23415.36560.stgit@kbuild-f20.novalocal> <20140922234250.23415.68758.stgit@kbuild-f20.novalocal> <20140923093610.4f404274@gandalf.local.home> In-Reply-To: <20140923093610.4f404274@gandalf.local.home> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2014/09/23 22:36), Steven Rostedt wrote: > For future reference: > > On Mon, 22 Sep 2014 23:42:50 +0000 > Masami Hiramatsu wrote: > >> ftracetest is a collection of testcase shell-scripts for ftrace. >> To avoid regressions of ftrace, these testcases check correct >> ftrace behaviors. If someone would like to add any features on >> ftrace, the patch series should have at least one testcase for >> checking the new behavior. >> >> Changes in v5: >> - Fix a TODO item, since this already integrated to kselftest. >> - Print the test name at the first line. >> >> Changes in v4: >> - Move this under selftests. :) >> - Add a copyright and note of GPLv2. >> - Fix documents acconding to Steven's comments. >> - Fix a small bug pointed by Namhyng. >> >> Changes in v3: >> - Use "." instead of "source". >> - Don't use -e option for echo since dash doesn't support it. >> >> Changes in v2: >> - Remove unneeded 'function' keyword. >> - Add abspath and find_testcases. >> - Make OPT_TEST_CASES a local var. >> - Ensure given testcase ended with .tc. >> - Accept a directory option which has multiple testcases. >> - Change [PASSED]/[FAILED] to [PASS]/[FAIL] >> - Change the basic shell to sh (dash). > > Place the version changes after the '---'. They are great for patch > series, but we prefer not to have them in the git logs. The "Link:" tag > should allow people to find the version history of patches if they are > interested. By placing the version updates after the '---', git will > ignore them when pulling them in. Ah, I see :) For the next series, I'll do that. > >> >> Signed-off-by: Masami Hiramatsu >> Acked-by: Shuah Khan >> --- > > Also, please have the Signed-off-by be the last tag, otherwise it > screws up my scripts ;-) OK. Thank you! -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Research Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com