From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomas Henzl Subject: Re: [PATCH] hpsa: add missing pci_set_master in kdump path Date: Wed, 24 Sep 2014 12:31:34 +0200 Message-ID: <54229D86.4050205@redhat.com> References: <5412EA9F.4060703@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:51133 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754363AbaIXKcD (ORCPT ); Wed, 24 Sep 2014 06:32:03 -0400 In-Reply-To: <5412EA9F.4060703@redhat.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: "'linux-scsi@vger.kernel.org'" Cc: elliott@hp.com, steve.cameron@hp.com, Christoph Hellwig , "Handzik, Joe" Christoph, this is a fix for 132aa220b45d60e9b20def1e9d8be9422eed9616 hpsa: refine the pci enable/disable handling which is in 'for-3.18'. If this patch will not be reviewed and added to 3.18 the aforementioned patch needs to be reverted. Tomas On 09/12/2014 02:44 PM, Tomas Henzl wrote: > Add a call to pci_set_master(...) missing in the previous > patch "hpsa: refine the pci enable/disable handling". > Found thanks to Rob Elliot. > --- > drivers/scsi/hpsa.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c > index 7828834..cef5d49 100644 > --- a/drivers/scsi/hpsa.c > +++ b/drivers/scsi/hpsa.c > @@ -6544,7 +6544,7 @@ static int hpsa_init_reset_devices(struct pci_dev *pdev) > dev_warn(&pdev->dev, "failed to enable device.\n"); > return -ENODEV; > } > - > + pci_set_master(pdev); > /* Reset the controller with a PCI power-cycle or via doorbell */ > rc = hpsa_kdump_hard_reset_controller(pdev); >