From: Paolo Bonzini <pbonzini@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Cc: dmitry@daynix.com, borntraeger@de.ibm.com, mst@redhat.com,
agraf@suse.de, cornelia.huck@de.ibm.com, kraxel@redhat.com,
amit.shah@redhat.com, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH 26/30] usb-storage: make its storage SCSI bus hotpluggable explicitly
Date: Wed, 24 Sep 2014 14:30:53 +0200 [thread overview]
Message-ID: <5422B97D.2020003@redhat.com> (raw)
In-Reply-To: <1411559299-19042-27-git-send-email-imammedo@redhat.com>
Il 24/09/2014 13:48, Igor Mammedov ha scritto:
> usb-storage uses SCSI bus to provide underling storage
> (i.e. scsi-disk) and it's hotpluggable. In addition
> during usb-storage hotplug bus_add_child() won't allow
> to add scsi-disk to SCSI bus owned by usb-storage
> if bus is not hotpluggable.
>
> By default SCSI bus was alway hotpluggable even if
> an owner didn't support hotplug. It will change
> once BusState.allow_hotplug field is dropped and
> SCSI bus will be only hotpluggable only if bus owner
> implements HOTPLUG_HANDLER interface.
>
> So make usb-storage implement HOTPLUG_HANDLER interface
> to keep its SCSI bus hotpluggable.
Correct. usb-bot unfortunately is not hot-pluggable because we would
plug it with no SCSI LUN inside. The guest would not be able to access
it. We would have to delay the presentation of the usb-bot device until
after the LUN is there. Perhaps some kind of transaction mechanism?
However, usb-storage builds the outer USB device and the inner SCSI
device at the same time, so it can be hot-plugged.
What you do for usb-storage should also be done for lsi, esp, usb-uas, etc.
Paolo
next prev parent reply other threads:[~2014-09-24 12:31 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 11:47 [Qemu-devel] [PATCH 00/30] complete conversion to hotplug-handler API Igor Mammedov
2014-09-24 11:47 ` [Qemu-devel] [PATCH 01/30] test: virtio-scsi: check if hot-plug/unplug works Igor Mammedov
2014-09-24 12:32 ` Paolo Bonzini
2014-09-24 11:47 ` [Qemu-devel] [PATCH 02/30] test: virtio-serial: " Igor Mammedov
2014-09-24 12:33 ` Paolo Bonzini
2014-09-24 11:47 ` [Qemu-devel] [PATCH 03/30] test: virtio-rng: " Igor Mammedov
2014-09-24 12:35 ` Paolo Bonzini
2014-09-24 11:47 ` [Qemu-devel] [PATCH 04/30] test: virtio-net: " Igor Mammedov
2014-09-24 12:35 ` Paolo Bonzini
2014-09-24 11:47 ` [Qemu-devel] [PATCH 05/30] test: virtio-blk: " Igor Mammedov
2014-09-24 12:35 ` Paolo Bonzini
2014-09-24 11:47 ` [Qemu-devel] [PATCH 06/30] test: usb: add port test to uhci unit test Igor Mammedov
2014-09-24 12:30 ` Gerd Hoffmann
2014-09-24 14:06 ` Igor Mammedov
2014-09-24 11:47 ` [Qemu-devel] [PATCH 07/30] test: usb: generic usb device hotplug Igor Mammedov
2014-09-24 11:47 ` [Qemu-devel] [PATCH 08/30] test: usb: usb-storage hotplug test Igor Mammedov
2014-09-24 11:47 ` [Qemu-devel] [PATCH 09/30] access BusState.allow_hotplug using wraper qbus_is_hotpluggable() Igor Mammedov
2014-09-24 12:32 ` Paolo Bonzini
2014-09-25 2:00 ` Tang Chen
2014-09-25 8:05 ` Igor Mammedov
2014-09-24 11:47 ` [Qemu-devel] [PATCH 10/30] qdev: HotplugHandler: rename unplug callback to unplug_request Igor Mammedov
2014-09-24 12:16 ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 11/30] qdev: HotplugHandler: provide unplug callback Igor Mammedov
2014-09-24 12:17 ` Paolo Bonzini
2014-09-25 1:53 ` Tang Chen
2014-09-25 8:07 ` Igor Mammedov
2014-09-24 11:48 ` [Qemu-devel] [PATCH 12/30] qdev: add simple/generic unplug callback for HotplugHandler Igor Mammedov
2014-09-24 12:17 ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 13/30] qdev: hotplug: set handler only if HOTPLUG_HANDLER interface is supported Igor Mammedov
2014-09-24 12:19 ` Paolo Bonzini
2014-09-24 14:01 ` Igor Mammedov
2014-09-25 2:06 ` Tang Chen
2014-09-24 11:48 ` [Qemu-devel] [PATCH 14/30] target-i386: ICC bus: replace BusState.allow_hotplug with hotplug_handler Igor Mammedov
2014-09-24 12:22 ` Paolo Bonzini
2014-09-24 14:37 ` Igor Mammedov
2014-09-24 14:50 ` Paolo Bonzini
2014-09-24 15:30 ` Igor Mammedov
2014-09-24 15:34 ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 15/30] virtio-pci: " Igor Mammedov
2014-09-24 12:23 ` Paolo Bonzini
2014-09-24 14:51 ` Igor Mammedov
2014-09-24 14:53 ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 16/30] virtio-serial: convert to hotplug-handler API Igor Mammedov
2014-09-24 12:24 ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 17/30] virtio-mmio: drop useless bus->allow_hotplug = 0 Igor Mammedov
2014-09-24 12:24 ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 18/30] s390x: drop not used allow_hotplug in event-facility Igor Mammedov
2014-09-24 12:24 ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 19/30] s390x: convert s390-virtio to hotplug handler API Igor Mammedov
2014-09-24 11:48 ` [Qemu-devel] [PATCH 20/30] s390x: convert virtio-ccw " Igor Mammedov
2014-09-25 11:08 ` Cornelia Huck
2014-09-25 13:11 ` Igor Mammedov
2014-09-25 14:32 ` Cornelia Huck
2014-09-25 15:26 ` Igor Mammedov
2014-09-24 11:48 ` [Qemu-devel] [PATCH 21/30] scsi: make scsi_bus_new() assign hotplug controller Igor Mammedov
2014-09-24 12:11 ` Paolo Bonzini
2014-09-24 12:14 ` Paolo Bonzini
2014-09-24 15:00 ` Igor Mammedov
2014-09-24 11:48 ` [Qemu-devel] [PATCH 22/30] scsi: convert pvscsi HBA to hotplug hander API Igor Mammedov
2014-09-24 12:13 ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 23/30] scsi: convert virtio-scsi HBA to hotplug handler API Igor Mammedov
2014-09-24 12:15 ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 24/30] scsi: cleanup not used anymore SCSIBusInfo{hotplug, hot_unplug} fields Igor Mammedov
2014-09-24 12:12 ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 25/30] usb-bot: drop not needed "allow_hotplug = 0" Igor Mammedov
2014-09-24 12:27 ` Paolo Bonzini
2014-09-24 15:15 ` Igor Mammedov
2014-09-24 15:21 ` Paolo Bonzini
2014-09-25 8:01 ` Gerd Hoffmann
2014-09-25 8:12 ` Igor Mammedov
2014-09-25 14:10 ` Gerd Hoffmann
2014-09-25 7:59 ` Gerd Hoffmann
2014-09-24 11:48 ` [Qemu-devel] [PATCH 26/30] usb-storage: make its storage SCSI bus hotpluggable explicitly Igor Mammedov
2014-09-24 12:30 ` Paolo Bonzini [this message]
2014-09-24 12:56 ` Gerd Hoffmann
2014-09-24 12:50 ` Gerd Hoffmann
2014-09-24 15:22 ` Igor Mammedov
2014-09-25 7:52 ` Gerd Hoffmann
2014-09-24 11:48 ` [Qemu-devel] [PATCH 27/30] usb-storage: drop not needed "allow_hotplug = 0" Igor Mammedov
2014-09-24 12:31 ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 28/30] usb: convert to hotplug handler API Igor Mammedov
2014-09-24 13:00 ` Gerd Hoffmann
2014-09-24 13:04 ` Paolo Bonzini
2014-09-24 13:23 ` Gerd Hoffmann
2014-09-24 15:39 ` Igor Mammedov
2014-09-25 7:50 ` Gerd Hoffmann
2014-09-25 10:55 ` Igor Mammedov
2014-09-25 12:47 ` Paolo Bonzini
2014-09-25 13:22 ` Igor Mammedov
2014-09-24 15:40 ` Igor Mammedov
2014-09-24 11:48 ` [Qemu-devel] [PATCH 29/30] qdev: drop legacy hotplug fields/methods Igor Mammedov
2014-09-24 12:04 ` Paolo Bonzini
2014-09-24 15:37 ` Igor Mammedov
2014-09-24 11:48 ` [Qemu-devel] [PATCH 30/30] qdev: HotplugHandler: add support for unplugging BUS-less devices Igor Mammedov
2014-09-24 12:00 ` Paolo Bonzini
2014-09-24 13:01 ` [Qemu-devel] [PATCH 00/30] complete conversion to hotplug-handler API Cornelia Huck
2014-09-24 14:20 ` Igor Mammedov
2014-09-24 15:01 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5422B97D.2020003@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=amit.shah@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=dmitry@daynix.com \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.