From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregory.clement@free-electrons.com (Gregory CLEMENT) Date: Wed, 24 Sep 2014 14:36:12 +0200 Subject: [linux-sunxi] Re: [PATCH 3/6] ARM: dts: sunxi: Add Allwinner A80 dtsi In-Reply-To: References: <1411311493-24344-1-git-send-email-wens@csie.org> <1411311493-24344-4-git-send-email-wens@csie.org> <20140924063738.GQ15315@lukather> <54227038.2020805@free-electrons.com> Message-ID: <5422BABC.7020906@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Chen-Yu, > > Thanks for the tip. Before I send v2, I do have a question. I'm using > > ranges = <0 0 0 0x20000000>; > > in the clocks and soc node to avoid having to use 64bit values for all > addresses and sizes. Would this be undesirable, even bad practice maybe? We did something like that for all the internal registers too as they are all under 4GB. In our case the use of a range really makes sens because the hardware addresses were configurable. You don't have such requirement so I can't say if it is a bad practice. From my point of view it seems sensible but I am not an DT expert. Gr?gory -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: Re: [PATCH 3/6] ARM: dts: sunxi: Add Allwinner A80 dtsi Date: Wed, 24 Sep 2014 14:36:12 +0200 Message-ID: <5422BABC.7020906@free-electrons.com> References: <1411311493-24344-1-git-send-email-wens@csie.org> <1411311493-24344-4-git-send-email-wens@csie.org> <20140924063738.GQ15315@lukather> <54227038.2020805@free-electrons.com> Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: Maxime Ripard , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linux-arm-kernel , devicetree , linux-kernel , Shuge , Meng Zhang , yhf , ctl , linux-sunxi List-Id: devicetree@vger.kernel.org Hi Chen-Yu, >=20 > Thanks for the tip. Before I send v2, I do have a question. I'm using >=20 > ranges =3D <0 0 0 0x20000000>; >=20 > in the clocks and soc node to avoid having to use 64bit values for all > addresses and sizes. Would this be undesirable, even bad practice maybe? We did something like that for all the internal registers too as they are a= ll under 4GB. In our case the use of a range really makes sens because the har= dware addresses were configurable. You don't have such requirement so I can't say= if it is a bad practice. From my point of view it seems sensible but I am not = an DT expert. Gr=C3=A9gory --=20 Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753071AbaIXMgV (ORCPT ); Wed, 24 Sep 2014 08:36:21 -0400 Received: from top.free-electrons.com ([176.31.233.9]:49938 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751543AbaIXMgU (ORCPT ); Wed, 24 Sep 2014 08:36:20 -0400 Message-ID: <5422BABC.7020906@free-electrons.com> Date: Wed, 24 Sep 2014 14:36:12 +0200 From: Gregory CLEMENT User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Chen-Yu Tsai CC: Maxime Ripard , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linux-arm-kernel , devicetree , linux-kernel , Shuge , Meng Zhang , yhf , ctl , linux-sunxi Subject: Re: [linux-sunxi] Re: [PATCH 3/6] ARM: dts: sunxi: Add Allwinner A80 dtsi References: <1411311493-24344-1-git-send-email-wens@csie.org> <1411311493-24344-4-git-send-email-wens@csie.org> <20140924063738.GQ15315@lukather> <54227038.2020805@free-electrons.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chen-Yu, > > Thanks for the tip. Before I send v2, I do have a question. I'm using > > ranges = <0 0 0 0x20000000>; > > in the clocks and soc node to avoid having to use 64bit values for all > addresses and sizes. Would this be undesirable, even bad practice maybe? We did something like that for all the internal registers too as they are all under 4GB. In our case the use of a range really makes sens because the hardware addresses were configurable. You don't have such requirement so I can't say if it is a bad practice. From my point of view it seems sensible but I am not an DT expert. Grégory -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com