From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 24 Sep 2014 15:00:59 +0200 (CEST) Received: from mailapp01.imgtec.com ([195.59.15.196]:38223 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27008868AbaIXNAyX2RvC (ORCPT ); Wed, 24 Sep 2014 15:00:54 +0200 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id 19126D8E4CDC for ; Wed, 24 Sep 2014 14:00:45 +0100 (IST) Received: from LEMAIL01.le.imgtec.org (192.168.152.62) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 24 Sep 2014 14:00:47 +0100 Received: from [192.168.154.101] (192.168.154.101) by LEMAIL01.le.imgtec.org (192.168.152.62) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 24 Sep 2014 14:00:46 +0100 Message-ID: <5422C07E.6080300@imgtec.com> Date: Wed, 24 Sep 2014 14:00:46 +0100 From: James Hogan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Paul Burton , Subject: Re: [PATCH 00/11] FP/MSA fixes References: <1411551942-11153-1-git-send-email-paul.burton@imgtec.com> In-Reply-To: <1411551942-11153-1-git-send-email-paul.burton@imgtec.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.101] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 42769 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: james.hogan@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 24/09/14 10:45, Paul Burton wrote: > This series fixes a bunch of bugs, both build & runtime, with FP & MSA > support. Most of them only affect systems with the new FP modes & MSA > support enabled but patch 6 in particular is more general, fixing > problems for mips64 systems. I don't claim to be particularly familiar with much of this code, but FWIW I've read it through and haven't spotted anything wrong aside from what has already been mentioned. Thanks James > > James Hogan (2): > Revert "MIPS: Don't assume 64-bit FP registers for context switch" > MIPS: MSA: Fix big-endian FPR_IDX implementation > > Paul Burton (9): > MIPS: push .set arch=r4000 into the functions needing it > MIPS: assume at as source/dest of MSA copy/insert instructions > MIPS: remove MSA macro recursion > MIPS: wrap cfcmsa & ctcmsa accesses for toolchains with MSA support > MIPS: clear MSACSR cause bits when handling MSA FP exception > MIPS: fix mfc1 & mfhc1 emulation for mips64 systems > MIPS: ensure FCSR cause bits are clear after invoking FPU emulator > MIPS: prevent FP context set via ptrace being discarded > MIPS: disable FPU if the mode is unsupported > > arch/mips/include/asm/asmmacro-32.h | 128 ++++++++++----------- > arch/mips/include/asm/asmmacro.h | 218 +++++++++++++++++++++--------------- > arch/mips/include/asm/fpu.h | 19 ++-- > arch/mips/include/asm/processor.h | 2 +- > arch/mips/kernel/asm-offsets.c | 66 ----------- > arch/mips/kernel/genex.S | 11 +- > arch/mips/kernel/ptrace.c | 30 ++++- > arch/mips/kernel/r4k_fpu.S | 13 ++- > arch/mips/kernel/traps.c | 17 +-- > arch/mips/math-emu/cp1emu.c | 6 +- > 10 files changed, 262 insertions(+), 248 deletions(-) > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp01.imgtec.com ([195.59.15.196]:38223 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27008868AbaIXNAyX2RvC (ORCPT ); Wed, 24 Sep 2014 15:00:54 +0200 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id 19126D8E4CDC for ; Wed, 24 Sep 2014 14:00:45 +0100 (IST) Message-ID: <5422C07E.6080300@imgtec.com> Date: Wed, 24 Sep 2014 14:00:46 +0100 From: James Hogan MIME-Version: 1.0 Subject: Re: [PATCH 00/11] FP/MSA fixes References: <1411551942-11153-1-git-send-email-paul.burton@imgtec.com> In-Reply-To: <1411551942-11153-1-git-send-email-paul.burton@imgtec.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Paul Burton , linux-mips@linux-mips.org Message-ID: <20140924130046.TM2Klle5G3aCo5hRpU9-bPxoeGnp5Rv17zOEdYp9kvs@z> On 24/09/14 10:45, Paul Burton wrote: > This series fixes a bunch of bugs, both build & runtime, with FP & MSA > support. Most of them only affect systems with the new FP modes & MSA > support enabled but patch 6 in particular is more general, fixing > problems for mips64 systems. I don't claim to be particularly familiar with much of this code, but FWIW I've read it through and haven't spotted anything wrong aside from what has already been mentioned. Thanks James > > James Hogan (2): > Revert "MIPS: Don't assume 64-bit FP registers for context switch" > MIPS: MSA: Fix big-endian FPR_IDX implementation > > Paul Burton (9): > MIPS: push .set arch=r4000 into the functions needing it > MIPS: assume at as source/dest of MSA copy/insert instructions > MIPS: remove MSA macro recursion > MIPS: wrap cfcmsa & ctcmsa accesses for toolchains with MSA support > MIPS: clear MSACSR cause bits when handling MSA FP exception > MIPS: fix mfc1 & mfhc1 emulation for mips64 systems > MIPS: ensure FCSR cause bits are clear after invoking FPU emulator > MIPS: prevent FP context set via ptrace being discarded > MIPS: disable FPU if the mode is unsupported > > arch/mips/include/asm/asmmacro-32.h | 128 ++++++++++----------- > arch/mips/include/asm/asmmacro.h | 218 +++++++++++++++++++++--------------- > arch/mips/include/asm/fpu.h | 19 ++-- > arch/mips/include/asm/processor.h | 2 +- > arch/mips/kernel/asm-offsets.c | 66 ----------- > arch/mips/kernel/genex.S | 11 +- > arch/mips/kernel/ptrace.c | 30 ++++- > arch/mips/kernel/r4k_fpu.S | 13 ++- > arch/mips/kernel/traps.c | 17 +-- > arch/mips/math-emu/cp1emu.c | 6 +- > 10 files changed, 262 insertions(+), 248 deletions(-) >