From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail2.candelatech.com ([208.74.158.173]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XWng6-0002nh-31 for ath10k@lists.infradead.org; Wed, 24 Sep 2014 14:36:23 +0000 Message-ID: <5422D6CF.10408@candelatech.com> Date: Wed, 24 Sep 2014 07:35:59 -0700 From: Ben Greear MIME-Version: 1.0 Subject: Re: [RFC 2/2] ath10k: re-config ht_caps when chainmask is modified. References: <1411518383-32634-1-git-send-email-greearb@candelatech.com> <1411518383-32634-2-git-send-email-greearb@candelatech.com> In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Michal Kazior Cc: linux-wireless , "ath10k@lists.infradead.org" CgpPbiAwOS8yNC8yMDE0IDEyOjUxIEFNLCBNaWNoYWwgS2F6aW9yIHdyb3RlOgo+IE9uIDI0IFNl cHRlbWJlciAyMDE0IDAyOjI2LCAgPGdyZWVhcmJAY2FuZGVsYXRlY2guY29tPiB3cm90ZToKPiBb Li4uXQo+PiArc3RhdGljIHN0cnVjdCBpZWVlODAyMTFfc3RhX3ZodF9jYXAgYXRoMTBrX2NyZWF0 ZV92aHRfY2FwKHN0cnVjdCBhdGgxMGsgKmFyLAo+PiArICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYm9vbCB1c2VfY2ZnX2NoYWlucykKPj4g ICB7Cj4+ICAgICAgICAgIHN0cnVjdCBpZWVlODAyMTFfc3RhX3ZodF9jYXAgdmh0X2NhcCA9IHsw fTsKPj4gICAgICAgICAgdTE2IG1jc19tYXA7Cj4+ICAgICAgICAgIGludCBpOwo+PiArICAgICAg IGludCBucmYgPSBhci0+bnVtX3JmX2NoYWluczsKPj4gKwo+PiArICAgICAgIGlmICh1c2VfY2Zn X2NoYWlucyAmJiBhci0+Y2ZnX3R4X2NoYWlubWFzaykKPj4gKyAgICAgICAgICAgICAgIG5yZiA9 IGdldF9uc3NfZnJvbV9jaGFpbm1hc2soYXItPmNmZ190eF9jaGFpbm1hc2spOwo+Cj4gSXMgdXNl X2NmZ19jaGFpbnMgcmVhbGx5IG5lY2Vzc2FyeSBoZXJlPyBJcyBzZXR0aW5nIHR4L3J4IGNoYWlu bWFzayB0bwo+IDB4MCBtYWtlIGFueSBzZW5zZSBhdCBhbGw/IFNob3VsZG4ndCB3ZSBkZW55IGl0 IG9yIG1ha2UgaXQgZmFsbGJhY2sgdG8KPiB0aGUgc3VwcG9ydGVkIHR4L3J4IGNoYWlubWFzayB2 YWx1ZXM/CgpJdCB3b3VsZCBjYXVzZSB0aGUgbG9naWMgdG8gZmxpcCBiYWNrIHRvIHRoZSBkZWZh dWx0cywgc28gc2VlbXMgbWlsZGx5IHVzZWZ1bC4gIEknbSBub3Qgc3VyZQp1cHBlciBsYXllcnMg d291bGQgZXZlciBsZXQgaXQgYmUgPCAxIHRob3VnaC4KClRoYW5rcywKQmVuCgo+Cj4KPiBNaWNo YcWCCj4KCi0tIApCZW4gR3JlZWFyIDxncmVlYXJiQGNhbmRlbGF0ZWNoLmNvbT4KQ2FuZGVsYSBU ZWNobm9sb2dpZXMgSW5jICBodHRwOi8vd3d3LmNhbmRlbGF0ZWNoLmNvbQoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYXRoMTBrIG1haWxpbmcgbGlzdAph dGgxMGtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2F0aDEwawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail2.candelatech.com ([208.74.158.173]:58181 "EHLO mail2.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753686AbaIXOgB (ORCPT ); Wed, 24 Sep 2014 10:36:01 -0400 Message-ID: <5422D6CF.10408@candelatech.com> (sfid-20140924_163610_502578_66EE33FB) Date: Wed, 24 Sep 2014 07:35:59 -0700 From: Ben Greear MIME-Version: 1.0 To: Michal Kazior CC: linux-wireless , "ath10k@lists.infradead.org" Subject: Re: [RFC 2/2] ath10k: re-config ht_caps when chainmask is modified. References: <1411518383-32634-1-git-send-email-greearb@candelatech.com> <1411518383-32634-2-git-send-email-greearb@candelatech.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 09/24/2014 12:51 AM, Michal Kazior wrote: > On 24 September 2014 02:26, wrote: > [...] >> +static struct ieee80211_sta_vht_cap ath10k_create_vht_cap(struct ath10k *ar, >> + bool use_cfg_chains) >> { >> struct ieee80211_sta_vht_cap vht_cap = {0}; >> u16 mcs_map; >> int i; >> + int nrf = ar->num_rf_chains; >> + >> + if (use_cfg_chains && ar->cfg_tx_chainmask) >> + nrf = get_nss_from_chainmask(ar->cfg_tx_chainmask); > > Is use_cfg_chains really necessary here? Is setting tx/rx chainmask to > 0x0 make any sense at all? Shouldn't we deny it or make it fallback to > the supported tx/rx chainmask values? It would cause the logic to flip back to the defaults, so seems mildly useful. I'm not sure upper layers would ever let it be < 1 though. Thanks, Ben > > > Michał > -- Ben Greear Candela Technologies Inc http://www.candelatech.com