From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail2.candelatech.com ([208.74.158.173]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XWoIJ-0004wD-UN for ath10k@lists.infradead.org; Wed, 24 Sep 2014 15:15:53 +0000 Message-ID: <5422E012.1030003@candelatech.com> Date: Wed, 24 Sep 2014 08:15:30 -0700 From: Ben Greear MIME-Version: 1.0 Subject: Re: [RFC 2/2] ath10k: re-config ht_caps when chainmask is modified. References: <1411518383-32634-1-git-send-email-greearb@candelatech.com> <1411518383-32634-2-git-send-email-greearb@candelatech.com> <5422D6CF.10408@candelatech.com> In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Michal Kazior Cc: linux-wireless , "ath10k@lists.infradead.org" CgpPbiAwOS8yNC8yMDE0IDA4OjA1IEFNLCBNaWNoYWwgS2F6aW9yIHdyb3RlOgo+IE9uIDI0IFNl cHRlbWJlciAyMDE0IDE2OjM1LCBCZW4gR3JlZWFyIDxncmVlYXJiQGNhbmRlbGF0ZWNoLmNvbT4g d3JvdGU6Cj4+IE9uIDA5LzI0LzIwMTQgMTI6NTEgQU0sIE1pY2hhbCBLYXppb3Igd3JvdGU6Cj4+ PiBPbiAyNCBTZXB0ZW1iZXIgMjAxNCAwMjoyNiwgIDxncmVlYXJiQGNhbmRlbGF0ZWNoLmNvbT4g d3JvdGU6Cj4+PiBbLi4uXQo+Pj4+Cj4+Pj4gK3N0YXRpYyBzdHJ1Y3QgaWVlZTgwMjExX3N0YV92 aHRfY2FwIGF0aDEwa19jcmVhdGVfdmh0X2NhcChzdHJ1Y3QgYXRoMTBrCj4+Pj4gKmFyLAo+Pj4+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBib29sCj4+Pj4gdXNlX2NmZ19jaGFpbnMpCj4+Pj4gICAgewo+Pj4+ICAgICAgICAgICBzdHJ1 Y3QgaWVlZTgwMjExX3N0YV92aHRfY2FwIHZodF9jYXAgPSB7MH07Cj4+Pj4gICAgICAgICAgIHUx NiBtY3NfbWFwOwo+Pj4+ICAgICAgICAgICBpbnQgaTsKPj4+PiArICAgICAgIGludCBucmYgPSBh ci0+bnVtX3JmX2NoYWluczsKPj4+PiArCj4+Pj4gKyAgICAgICBpZiAodXNlX2NmZ19jaGFpbnMg JiYgYXItPmNmZ190eF9jaGFpbm1hc2spCj4+Pj4gKyAgICAgICAgICAgICAgIG5yZiA9IGdldF9u c3NfZnJvbV9jaGFpbm1hc2soYXItPmNmZ190eF9jaGFpbm1hc2spOwo+Pj4KPj4+Cj4+PiBJcyB1 c2VfY2ZnX2NoYWlucyByZWFsbHkgbmVjZXNzYXJ5IGhlcmU/IElzIHNldHRpbmcgdHgvcnggY2hh aW5tYXNrIHRvCj4+PiAweDAgbWFrZSBhbnkgc2Vuc2UgYXQgYWxsPyBTaG91bGRuJ3Qgd2UgZGVu eSBpdCBvciBtYWtlIGl0IGZhbGxiYWNrIHRvCj4+PiB0aGUgc3VwcG9ydGVkIHR4L3J4IGNoYWlu bWFzayB2YWx1ZXM/Cj4+Cj4+IEl0IHdvdWxkIGNhdXNlIHRoZSBsb2dpYyB0byBmbGlwIGJhY2sg dG8gdGhlIGRlZmF1bHRzLCBzbyBzZWVtcyBtaWxkbHkKPj4gdXNlZnVsLiAgSSdtIG5vdCBzdXJl Cj4+IHVwcGVyIGxheWVycyB3b3VsZCBldmVyIGxldCBpdCBiZSA8IDEgdGhvdWdoLgo+Cj4gMCBp cyBhIHZhbGlkIGFyZ3VtZW50IGFzIGZhciBhcyB1cHBlciBsYXllcnMgYXJlIGNvbmNlcm5lZCBh bmQgc2hvdWxkCj4gYmUgdHJlYXRlZCBhcyAidXNlIGFsbCBhdmFpbGFibGUgYW50ZW5uYXMiIChz ZWUgYGl3IGxpc3RgIG91dHB1dAo+IGJlZm9yZSBldmVyIHNldHRpbmcgYW50ZW5uYSwgYWZ0ZXIg c2V0dGluZyB0bywgZS5nLiAxIGFuZCB0aGVuIHRvIDApLgo+Cj4gVGhpcyBpbXBsaWVzIGN1cnJl bnQgc2V0X2FudGVubmEoKSBpbXBsZW1lbnRhdGlvbiBpcyBhY3R1YWxseSBidWdneQo+IChwZGV2 IHBhcmFtIHNob3VsZCBpbnZvbHZlIHVzaW5nIHN1cHBfdHgvcnhfY2hhaW5tYXNrKS4gWW91cgo+ IGFzc3VtcHRpb24gaW4gcmVjZW50IHBhdGNoZXMgaXMgYWxzbyBpbmNvcnJlY3QgYXMgYW50ZW5u YSBtYXNrID0gMAo+IHNob3VsZCBpbXBseSBtYXggbnNzLCBub3QgMS4KCkkgd2lsbCB0ZXN0LCBi dXQgSSB0aGluayB5b3UgYXJlIG1pcy11bmRlcnN0YW5kaW5nIHRoZSBsb2dpYyBpbiBteQpwYXRj aGVzLiAgSSBzaG91bGQgYmUgdXNpbmcgdGhlIG1heCBuc3Mgd2hlbmV2ZXIgY29uZmlndXJlZCB2 YWx1ZQppcyAwLgoKVGhhbmtzLApCZW4KCj4KPgo+IE1pY2hhxYIKPgoKLS0gCkJlbiBHcmVlYXIg PGdyZWVhcmJAY2FuZGVsYXRlY2guY29tPgpDYW5kZWxhIFRlY2hub2xvZ2llcyBJbmMgIGh0dHA6 Ly93d3cuY2FuZGVsYXRlY2guY29tCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwphdGgxMGsgbWFpbGluZyBsaXN0CmF0aDEwa0BsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vYXRoMTBrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail2.candelatech.com ([208.74.158.173]:58706 "EHLO mail2.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754863AbaIXPPb (ORCPT ); Wed, 24 Sep 2014 11:15:31 -0400 Message-ID: <5422E012.1030003@candelatech.com> (sfid-20140924_171559_965827_618029DB) Date: Wed, 24 Sep 2014 08:15:30 -0700 From: Ben Greear MIME-Version: 1.0 To: Michal Kazior CC: linux-wireless , "ath10k@lists.infradead.org" Subject: Re: [RFC 2/2] ath10k: re-config ht_caps when chainmask is modified. References: <1411518383-32634-1-git-send-email-greearb@candelatech.com> <1411518383-32634-2-git-send-email-greearb@candelatech.com> <5422D6CF.10408@candelatech.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 09/24/2014 08:05 AM, Michal Kazior wrote: > On 24 September 2014 16:35, Ben Greear wrote: >> On 09/24/2014 12:51 AM, Michal Kazior wrote: >>> On 24 September 2014 02:26, wrote: >>> [...] >>>> >>>> +static struct ieee80211_sta_vht_cap ath10k_create_vht_cap(struct ath10k >>>> *ar, >>>> + bool >>>> use_cfg_chains) >>>> { >>>> struct ieee80211_sta_vht_cap vht_cap = {0}; >>>> u16 mcs_map; >>>> int i; >>>> + int nrf = ar->num_rf_chains; >>>> + >>>> + if (use_cfg_chains && ar->cfg_tx_chainmask) >>>> + nrf = get_nss_from_chainmask(ar->cfg_tx_chainmask); >>> >>> >>> Is use_cfg_chains really necessary here? Is setting tx/rx chainmask to >>> 0x0 make any sense at all? Shouldn't we deny it or make it fallback to >>> the supported tx/rx chainmask values? >> >> It would cause the logic to flip back to the defaults, so seems mildly >> useful. I'm not sure >> upper layers would ever let it be < 1 though. > > 0 is a valid argument as far as upper layers are concerned and should > be treated as "use all available antennas" (see `iw list` output > before ever setting antenna, after setting to, e.g. 1 and then to 0). > > This implies current set_antenna() implementation is actually buggy > (pdev param should involve using supp_tx/rx_chainmask). Your > assumption in recent patches is also incorrect as antenna mask = 0 > should imply max nss, not 1. I will test, but I think you are mis-understanding the logic in my patches. I should be using the max nss whenever configured value is 0. Thanks, Ben > > > Michał > -- Ben Greear Candela Technologies Inc http://www.candelatech.com