Re: [Qemu-devel] [PATCH v3] docs: add blkdebug block driver documentation

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1227 bytes --]

On 09/24/2014 03:44 AM, Stefan Hajnoczi wrote:
> The blkdebug block driver is undocumented.  Documenting it is worthwhile
> since it offers powerful error injection features that are used by
> qemu-iotests test cases.
> 
> This document will make it easier for people to learn about and use
> blkdebug.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> v3:
>  * Fix tab space damage [Eric]
>  * Rephrase event_names[] as full list of events [Eric]
>  * Explain that blkdebug state is not observable from outside [Eric]
>  * Clarify state 0 and state 1 [Eric]

Thanks for the updates.

Reviewed-by: Eric Blake <eblake@redhat.com>


> +
> +The error injection engine has an integer called the "state" that always starts
> +initialized to 1.  The state integer is internal to blkdebug and cannot be
> +observed from outside but rules can interact with it for powerful matching
> +behavior.
> +

We could always expose it and update the documentation in a later patch.
 But it is fair to document the current state of things (current docs
are always better than no docs :)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]