From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH for-4.5 v6 04/16] xen: Add vmware_port
	support
Date: Wed, 24 Sep 2014 18:42:52 +0100
Message-ID: <5423029C.8020903@citrix.com>
References: <1411236447-7435-1-git-send-email-dslutz@verizon.com>	<1411236447-7435-5-git-send-email-dslutz@verizon.com>	<5422EAEB.2050807@eu.citrix.com>
	<5422F5DF.5070902@terremark.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5422F5DF.5070902@terremark.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Don Slutz <dslutz@verizon.com>, George Dunlap <george.dunlap@eu.citrix.com>, xen-devel@lists.xen.org
Cc: Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Eddie Dong <eddie.dong@intel.com>, Tim Deegan <tim@xen.org>, Jan Beulich <jbeulich@suse.com>, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>, Jun Nakajima <jun.nakajima@intel.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
List-Id: xen-devel@lists.xenproject.org

On 24/09/14 17:48, Don Slutz wrote:
> On 09/24/14 12:01, George Dunlap wrote:
>> On 09/20/2014 07:07 PM, Don Slutz wrote:
>>
>>> diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
>>> index 7b1dfe6..e2e4aad 100644
>>> --- a/xen/arch/x86/domain.c
>>> +++ b/xen/arch/x86/domain.c
>>> @@ -510,6 +510,8 @@ int arch_domain_create(struct domain *d,
>>> unsigned int domcr_flags)
>>>       d->arch.hvm_domain.mem_sharing_enabled = 0;
>>>         d->arch.s3_integrity = !!(domcr_flags & DOMCRF_s3_integrity);
>>> +    d->arch.hvm_domain.is_vmware_port_enabled =
>>> +        (domcr_flags & DOMCRF_vmware_port);
>>
>> Should this be "!!(domcr..."?
>>
>
> I do not think it is needed, but happy to change to that.

It sadly is as bool_t isn't of type _Bool as one would expect.  It is
int8_t as Xen's bool_t pre-dates the general acceptance of using header
files such as <stdbool.h>

~Andrew