From: Behan Webster <behanw@converseincode.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: mq@suse.cz, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"H. Peter Anvin" <hpa@linux.intel.com>,
Tom Gundersen <teg@jklm.no>,
Masahiro Yamada <yamada.m@jp.panasonic.com>,
fengguang.wu@intel.com
Subject: Re: [PATCH] kbuild, LLVMLinux: Fix asm-offset generation to work with clang
Date: Wed, 24 Sep 2014 11:27:06 -0700 [thread overview]
Message-ID: <54230CFA.10003@converseincode.com> (raw)
In-Reply-To: <3907075.FRP0QfugZW@wuerfel>
On 09/24/14 03:37, Arnd Bergmann wrote:
> On Tuesday 23 September 2014 12:25:31 behanw@converseincode.com wrote:
>> #define DEFINE(sym, val) \
>> - asm volatile("\n->" #sym " %0 " #val : : "i" (val))
>> + asm volatile("\n@->" #sym " %0 " #val : : "i" (val))
> Isn't the '@' character to start a comment architecture specific?
I had worried about that as well (as we discussed at LCU), but with the
limited testing I tried this with it seemed to indicate that gas was
smart enough to handle it in most cases. However the kbuild test robot
indicates that this patch breaks MIPS. So indeed your concern is justified.
Gotta love the kbuild test robot. Thank you Fengguang Wu!
> If this makes it work on ARM, what about other architectures?
For now, I think I need to try something else.
Thanks,
Behan
--
Behan Webster
behanw@converseincode.com
prev parent reply other threads:[~2014-09-24 18:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 19:25 [PATCH] kbuild, LLVMLinux: Fix asm-offset generation to work with clang behanw
2014-09-24 10:37 ` Arnd Bergmann
2014-09-24 18:27 ` Behan Webster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54230CFA.10003@converseincode.com \
--to=behanw@converseincode.com \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=fengguang.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mq@suse.cz \
--cc=teg@jklm.no \
--cc=yamada.m@jp.panasonic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.