From: kever.yang@rock-chips.com (Kever Yang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: rockchip: add missing rk3288 npll rate table
Date: Thu, 25 Sep 2014 09:35:30 +0800 [thread overview]
Message-ID: <54237162.5030601@rock-chips.com> (raw)
In-Reply-To: <CAD=FV=WCZt5cQ3Z4wWHyqgOh32X-Hztnyzs3-fpXh2nj7ROyfQ@mail.gmail.com>
Doug,
On 09/25/2014 06:51 AM, Doug Anderson wrote:
> Heiko,
>
> On Wed, Sep 24, 2014 at 2:41 PM, Heiko St?bner <heiko@sntech.de> wrote:
>> The npll on rk3288 is exactly the same pll type as the other 4. Yet it
>> was missing the link to the rate table, making rate changes impossible.
>> Change that by setting the table.
>>
>> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
>> ---
>> drivers/clk/rockchip/clk-rk3288.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/clk/rockchip/clk-rk3288.c b/drivers/clk/rockchip/clk-rk3288.c
>> index 8ea885b..938d30b 100644
>> --- a/drivers/clk/rockchip/clk-rk3288.c
>> +++ b/drivers/clk/rockchip/clk-rk3288.c
>> @@ -143,7 +143,7 @@ static struct rockchip_pll_clock rk3288_pll_clks[] __initdata = {
>> [gpll] = PLL(pll_rk3066, PLL_GPLL, "gpll", mux_pll_p, 0, RK3288_PLL_CON(12),
>> RK3288_MODE_CON, 12, 8, rk3288_pll_rates),
>> [npll] = PLL(pll_rk3066, PLL_NPLL, "npll", mux_pll_p, 0, RK3288_PLL_CON(16),
>> - RK3288_MODE_CON, 14, 9, NULL),
>> + RK3288_MODE_CON, 14, 9, rk3288_pll_rates),
>> };
> Works for me. Any reason not to add it to dpll, too?
dpll is used for DDR controller only, I'm not sure memory scaling driver
will use
the clock module API, because the code for memory scaling must moved to
intmem
(dram is not available at that time), which need to be small enough, and
it's not
possible to use the API from clock module.
So, I think it is no need to add the rate table to dpll.
-Kever
next prev parent reply other threads:[~2014-09-25 1:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 21:41 [PATCH] clk: rockchip: add missing rk3288 npll rate table Heiko Stübner
2014-09-24 22:51 ` Doug Anderson
2014-09-25 1:35 ` Kever Yang [this message]
2014-09-25 3:56 ` Doug Anderson
2014-09-25 1:36 ` Kever Yang
2014-09-25 21:49 ` Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54237162.5030601@rock-chips.com \
--to=kever.yang@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.