From: Zdenek Kabelac <zkabelac@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] pvcreate: check the label after writing
Date: Thu, 25 Sep 2014 09:52:06 +0200 [thread overview]
Message-ID: <5423C9A6.8000304@redhat.com> (raw)
In-Reply-To: <1411611632-2856-1-git-send-email-lzhong@suse.com>
Dne 25.9.2014 v 04:20 Lidong Zhong napsal(a):
> Some device will place metadata area at the beginning part and writing
> label may fail.Take our test for example, when running pvcreate on a CDL
> formatted DASD device(without partition), it shows successfully create
> a pv, but the label is not written on the second sector and pvs shows
> nothing. Although it is not supposed to run lvm on dasd device, it's a
> friendly behavior to check the label and return error if it fails.
Hmm - if device drive tells you - it has accepted and written some bytes
on your storage device - they really should be written there.
So IMHO driver should not lie and reject write request with error ?
Otherwise you would need to validate every single written byte by LVM ?
Maybe DASD devices should by automatically ignored by lvm filtering
as unusable device for PV (just like i.e. too small devices)
Zdenek
next prev parent reply other threads:[~2014-09-25 7:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 2:20 [PATCH] pvcreate: check the label after writing Lidong Zhong
2014-09-25 7:52 ` Zdenek Kabelac [this message]
2014-09-25 8:37 ` Zdenek Kabelac
2014-09-26 3:21 ` Lidong Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5423C9A6.8000304@redhat.com \
--to=zkabelac@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.