From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53182) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XX5cx-0005E5-8c for qemu-devel@nongnu.org; Thu, 25 Sep 2014 05:46:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XX5cp-00042V-5l for qemu-devel@nongnu.org; Thu, 25 Sep 2014 05:46:19 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:47293) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XX5cp-00040l-0u for qemu-devel@nongnu.org; Thu, 25 Sep 2014 05:46:11 -0400 Received: by mail-pa0-f51.google.com with SMTP id eu11so9001264pac.38 for ; Thu, 25 Sep 2014 02:46:05 -0700 (PDT) Message-ID: <5423E29C.3030902@ozlabs.ru> Date: Thu, 25 Sep 2014 19:38:36 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1411604219-15029-1-git-send-email-aik@ozlabs.ru> <1411632559.7154.8.camel@nilsson.home.kraxel.org> In-Reply-To: <1411632559.7154.8.camel@nilsson.home.kraxel.org> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] ohci: Split long traces to smaller ones List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On 09/25/2014 06:09 PM, Gerd Hoffmann wrote: > On Do, 2014-09-25 at 10:16 +1000, Alexey Kardashevskiy wrote: >> Recent traces rework introduced 2 tracepoints with 13 and 20 >> arguments. When dtrace backend is selected >> (--enable-trace-backend=dtrace), compile fails as >> sys/sdt.h defines DTRACE_PROBE up to DTRACE_PROBE12 only. >> >> This splits long tracepoints. > > Can you also change the tracing-enabled check to use '#ifndef > CONFIG_TRACE_NOP' as suggested by Stefan please? Nope :( As I said in that thread, I am not familiar with "dtrace" - are traces configurable with it? With --enable-trace-backend=dtrace, trace_event_get_state is not defined so CONFIG_TRACE_NOP is not 100% equal replacement. -- Alexey