All of lore.kernel.org
 help / color / mirror / Atom feed
From: Schrey <debian-kernel@schreyben.de>
To: linux-kernel@vger.kernel.org
Subject: Re: linux-stable: backport usb related commit to 3.10 and 3.12?
Date: Thu, 25 Sep 2014 13:02:28 +0200	[thread overview]
Message-ID: <5423F644.50707@schreyben.de> (raw)
In-Reply-To: <53F878AD.1000408@schreyben.de>

Hi,

resending; multiple systems are and have been working fine
for me, with that commit backported to kernel 3.10 and 3.12.

2014-08-23:
> Greetings.
>
> On an administered server, I noticed that there's a constant load
> around 0.70 when running kernels 3.10 and 3.12, even if
> the system is doing nothing, and in single user mode.
> Culprit seems to be the process 'khubd'.
> No such effect when running kernels 3.4 or 3.14.
>
> I reverse bisected linux-stable and found that the following commit
> fixes it for me, for both kernel 3.10 and 3.12:
>
> [08d1dec6f4054e3613f32051d9b149d4203ce0d2] usb:hub set 
> hub->change_bits when over-current happens
>
>
> Could that commit be backported to the stable 3.10 and 3.12 series?
>
> (Disclaimer: I'm not a programmer, but I'd be happy to help with any 
> testing involved)
>
> Regards
> Ingmar
>
> -------------------------------------------------------------------------- 
>
>
> $ git diff ac5166bcdb43889a5bd837f5076b78049e1f8bca 
> 08d1dec6f4054e3613f32051d9b149d4203ce0d2
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index c1422a0..babba88 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -1147,7 +1147,8 @@ static void hub_activate(struct usb_hub *hub, 
> enum hub_activation_type type)
>                         /* Tell khubd to disconnect the device or
>                          * check for a new connection
>                          */
> -                       if (udev || (portstatus & 
> USB_PORT_STAT_CONNECTION))
> +                       if (udev || (portstatus & 
> USB_PORT_STAT_CONNECTION) ||
> +                           (portstatus & USB_PORT_STAT_OVERCURRENT))
>                                 set_bit(port1, hub->change_bits);
>
>                 } else if (portstatus & USB_PORT_STAT_ENABLE) {
>
>


-- 
this space for rent


  reply	other threads:[~2014-09-25 11:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-23 11:19 linux-stable: backport usb related commit to 3.10 and 3.12? Schrey
2014-09-25 11:02 ` Schrey [this message]
2014-09-25 14:20 ` Frans Klaver
2014-09-25 14:22   ` Frans Klaver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5423F644.50707@schreyben.de \
    --to=debian-kernel@schreyben.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.