From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36680)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XX8fD-0000mT-7k
	for qemu-devel@nongnu.org; Thu, 25 Sep 2014 09:00:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XX8f7-0005fr-4o
	for qemu-devel@nongnu.org; Thu, 25 Sep 2014 09:00:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:27187)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XX8f6-0005f2-Ph
	for qemu-devel@nongnu.org; Thu, 25 Sep 2014 09:00:45 -0400
Message-ID: <54240EE3.10102@redhat.com>
Date: Thu, 25 Sep 2014 14:47:31 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1411559299-19042-1-git-send-email-imammedo@redhat.com>	<1411559299-19042-29-git-send-email-imammedo@redhat.com>	<1411563641.30748.7.camel@nilsson.home.kraxel.org>	<5422C168.9030001@redhat.com>	<1411565021.30748.9.camel@nilsson.home.kraxel.org>	<20140924173958.5a150ec5@nial.usersys.redhat.com>	<1411631458.7154.1.camel@nilsson.home.kraxel.org>
	<20140925125509.5454c0d8@nial.usersys.redhat.com>
In-Reply-To: <20140925125509.5454c0d8@nial.usersys.redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 28/30] usb: convert to hotplug handler API
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Cc: dmitry@daynix.com, mst@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, cornelia.huck@de.ibm.com, amit.shah@redhat.com, borntraeger@de.ibm.com, rth@twiddle.net

Il 25/09/2014 12:55, Igor Mammedov ha scritto:
> hotplug-handler.[plug|unplug] callbacks are class wide, so if
> USB bus might ever need to have different callbacks depending on
> host it might not work.
> 
> But since so far it uses the only qdev_simple_device_unplug_cb(),
> having BUS as hotplug-handler should work too.

Yeah, in effect the USB bus is using attach/detach as the
controller-specific part of the hotplug handler.

Perhaps the same can work for SCSI as well?  I'm waiting for v2. :)

Paolo