From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail2.candelatech.com ([208.74.158.173]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XX90R-00021O-KE for ath10k@lists.infradead.org; Thu, 25 Sep 2014 13:22:48 +0000 Message-ID: <5424170B.2010409@candelatech.com> Date: Thu, 25 Sep 2014 06:22:19 -0700 From: Ben Greear MIME-Version: 1.0 Subject: Re: [PATCH] ath10k: use configured nss instead of max nss. References: <1411426820-4047-1-git-send-email-greearb@candelatech.com> <5421A44C.8080307@candelatech.com> <5422ECAA.6050600@candelatech.com> In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Michal Kazior Cc: linux-wireless , "ath10k@lists.infradead.org" CgpPbiAwOS8yNC8yMDE0IDExOjE2IFBNLCBNaWNoYWwgS2F6aW9yIHdyb3RlOgo+IE9uIDI0IFNl cHRlbWJlciAyMDE0IDE4OjA5LCBCZW4gR3JlZWFyIDxncmVlYXJiQGNhbmRlbGF0ZWNoLmNvbT4g d3JvdGU6Cj4+IE9uIDA5LzI0LzIwMTQgMTI6MDkgQU0sIE1pY2hhbCBLYXppb3Igd3JvdGU6Cj4+ PiBPbiAyMyBTZXB0ZW1iZXIgMjAxNCAxODo0OCwgQmVuIEdyZWVhciA8Z3JlZWFyYkBjYW5kZWxh dGVjaC5jb20+IHdyb3RlOgo+Pj4+IE9uIDA5LzIzLzIwMTQgMDE6NTkgQU0sIE1pY2hhbCBLYXpp b3Igd3JvdGU6Cj4+Pj4+IE9uIDIzIFNlcHRlbWJlciAyMDE0IDAxOjAwLCAgPGdyZWVhcmJAY2Fu ZGVsYXRlY2guY29tPiB3cm90ZToKPj4+Pj4+IEZyb206IEJlbiBHcmVlYXIgPGdyZWVhcmJAY2Fu ZGVsYXRlY2guY29tPgo+Pj4gWy4uLl0KPj4+Pj4+IEBAIC00MDg2LDYgKzQwODYsMTAgQEAgYXRo MTBrX2RlZmF1bHRfYml0cmF0ZV9tYXNrKHN0cnVjdCBhdGgxMGsgKmFyLAo+Pj4+Pj4gICAgICAg ICAgdTMyIGxlZ2FjeSA9IDB4MDBmZjsKPj4+Pj4+ICAgICAgICAgIHU4IGh0ID0gMHhmZiwgaTsK Pj4+Pj4+ICAgICAgICAgIHUxNiB2aHQgPSAweDNmZjsKPj4+Pj4+ICsgICAgICAgdTE2IG5yZiA9 IGFyLT5udW1fcmZfY2hhaW5zOwo+Pj4+Pj4gKwo+Pj4+Pj4gKyAgICAgICBpZiAoYXItPmNmZ190 eF9jaGFpbm1hc2spCj4+Pj4+PiArICAgICAgICAgICAgICAgbnJmID0gZ2V0X25zc19mcm9tX2No YWlubWFzayhhci0+Y2ZnX3R4X2NoYWlubWFzayk7Cj4+PiBbLi4uXQo+Pj4+PiBJIHRoaW5rIGl0 IG1pZ2h0IGJlIGEgZ29vZCBpZGVhIHRvIGNvbnZleSB0aGUgbGltaXRhdGlvbiBvZiB0eC9yeAo+ Pj4+PiBjaGFpbm1hc2sgdG8gdGhlIHVzZXI6IHlvdSBjYW4ndCBjaGFuZ2UgdGhlIHR4L3J4IGNo YWlubWFzayBvbiB0aGUgZmx5Cj4+Pj4+IGVhc2lseSAod2hpbGUgY29ubmVjdGVkL2hhdmUgYXNz b2NpYXRlZCBzdGF0aW9ucykuIE9yIGRvIHlvdSBwbGFuIHRvCj4+Pj4+IHNjaGVkdWxlIHBlZXIg cmVhc3NvYyBpbiBfX2F0aDEwa19zZXRfYW50ZW5uYSgpIGluIGEgZm9sbG93IHVwCj4+Pj4+IHBh dGNoKGVzKSBsYXRlcj8KPiBbLi4uXQo+PiBTZWUgdGhpcyBpbiBuZXQvbWFjODAyMTEvY2ZnLmM6 Cj4+Cj4+IHN0YXRpYyBpbnQgaWVlZTgwMjExX3NldF9hbnRlbm5hKHN0cnVjdCB3aXBoeSAqd2lw aHksIHUzMiB0eF9hbnQsIHUzMiByeF9hbnQpCj4+IHsKPj4gICAgICAgICAgc3RydWN0IGllZWU4 MDIxMV9sb2NhbCAqbG9jYWwgPSB3aXBoeV9wcml2KHdpcGh5KTsKPj4KPj4gICAgICAgICAgaWYg KGxvY2FsLT5zdGFydGVkKQo+PiAgICAgICAgICAgICAgICAgIHJldHVybiAtRU9QTk9UU1VQUDsK Pgo+IEFoLCB0aGFua3MhIFNvIG15IGFyZ3VtZW50IGlzIGludmFsaWQgOikKPgo+Cj4+PiBCdXQg aXQncyBzdGlsbCBwcm9iYWJseSBhIGdvb2QgaWRlYSB0byBjb21tZW50IHRoZSBxdW90ZWQgY29k ZSBjaHVuawo+Pj4gYWJvdmUgZXhwbGFpbmluZyB3aHkgbnJmIGlzIG92ZXJyaWRlbiBieSBjaGFp bm1hc2sgKGkuZS4gZHVlIHRvCj4+PiBmaXJtd2FyZSByYXRlIGNvbnRyb2wgaXNzdWVzLCByaWdo dD8pLgo+Pgo+PiBJIGFtIG5vdCBjZXJ0YWluIGl0IGlzIGEgYnVnIGluIHRoZSBmaXJtd2FyZS4g IFRoZSBkcml2ZXIgc2hvdWxkIG5vdCBjb25maWd1cmUKPj4gbnNzIGluY29ycmVjdGx5IGFzIGl0 IHdhcyBkb2luZyBwcmV2aW91cyB0byBteSByZWNlbnQgcGF0Y2hlcy4KPgo+IFNpbmNlIGZpcm13 YXJlIGRvZXMgcmF0ZSBjb250cm9sIGl0IGp1c3Qgc2VlbXMgcmVkdW5kYW50IGZvciB0aGUKPiBk cml2ZXIgdG8gdXBkYXRlIGJvdGggY2hhaW5tYXNrIGFuZCBuc3MgKHRoZSBmaXJzdCBpbXBsaWVz IHRoZSBvdGhlcikuCj4gQnV0IG1heWJlIHRoYXQncyBqdXN0IG1lLgoKbnNzIGlzIHJlYWxseSBh IHBlci1zdGF0aW9uIGlzc3VlLCB3aGVyZSB0aGUgY2hhaW5tYXNrIGlzIGEgcGVyLXJhZGlvIGlz c3VlLgoKVGhpbmsgb2YgYW4gQVAgd2l0aCAyeDIgYW5kIDN4MyBzdGF0aW9ucyBjb25uZWN0ZWQs IGZvciBpbnN0YW5jZS4KClRoYW5rcywKQmVuCgo+Cj4KPiBNaWNoYcWCCj4KCi0tIApCZW4gR3Jl ZWFyIDxncmVlYXJiQGNhbmRlbGF0ZWNoLmNvbT4KQ2FuZGVsYSBUZWNobm9sb2dpZXMgSW5jICBo dHRwOi8vd3d3LmNhbmRlbGF0ZWNoLmNvbQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KYXRoMTBrIG1haWxpbmcgbGlzdAphdGgxMGtAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2F0aDEw awo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail2.candelatech.com ([208.74.158.173]:41638 "EHLO mail2.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751600AbaIYNWV (ORCPT ); Thu, 25 Sep 2014 09:22:21 -0400 Message-ID: <5424170B.2010409@candelatech.com> (sfid-20140925_152224_809654_A93B0F7C) Date: Thu, 25 Sep 2014 06:22:19 -0700 From: Ben Greear MIME-Version: 1.0 To: Michal Kazior CC: linux-wireless , "ath10k@lists.infradead.org" Subject: Re: [PATCH] ath10k: use configured nss instead of max nss. References: <1411426820-4047-1-git-send-email-greearb@candelatech.com> <5421A44C.8080307@candelatech.com> <5422ECAA.6050600@candelatech.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 09/24/2014 11:16 PM, Michal Kazior wrote: > On 24 September 2014 18:09, Ben Greear wrote: >> On 09/24/2014 12:09 AM, Michal Kazior wrote: >>> On 23 September 2014 18:48, Ben Greear wrote: >>>> On 09/23/2014 01:59 AM, Michal Kazior wrote: >>>>> On 23 September 2014 01:00, wrote: >>>>>> From: Ben Greear >>> [...] >>>>>> @@ -4086,6 +4086,10 @@ ath10k_default_bitrate_mask(struct ath10k *ar, >>>>>> u32 legacy = 0x00ff; >>>>>> u8 ht = 0xff, i; >>>>>> u16 vht = 0x3ff; >>>>>> + u16 nrf = ar->num_rf_chains; >>>>>> + >>>>>> + if (ar->cfg_tx_chainmask) >>>>>> + nrf = get_nss_from_chainmask(ar->cfg_tx_chainmask); >>> [...] >>>>> I think it might be a good idea to convey the limitation of tx/rx >>>>> chainmask to the user: you can't change the tx/rx chainmask on the fly >>>>> easily (while connected/have associated stations). Or do you plan to >>>>> schedule peer reassoc in __ath10k_set_antenna() in a follow up >>>>> patch(es) later? > [...] >> See this in net/mac80211/cfg.c: >> >> static int ieee80211_set_antenna(struct wiphy *wiphy, u32 tx_ant, u32 rx_ant) >> { >> struct ieee80211_local *local = wiphy_priv(wiphy); >> >> if (local->started) >> return -EOPNOTSUPP; > > Ah, thanks! So my argument is invalid :) > > >>> But it's still probably a good idea to comment the quoted code chunk >>> above explaining why nrf is overriden by chainmask (i.e. due to >>> firmware rate control issues, right?). >> >> I am not certain it is a bug in the firmware. The driver should not configure >> nss incorrectly as it was doing previous to my recent patches. > > Since firmware does rate control it just seems redundant for the > driver to update both chainmask and nss (the first implies the other). > But maybe that's just me. nss is really a per-station issue, where the chainmask is a per-radio issue. Think of an AP with 2x2 and 3x3 stations connected, for instance. Thanks, Ben > > > Michał > -- Ben Greear Candela Technologies Inc http://www.candelatech.com