From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yijing Wang Subject: Re: [PATCH v2 14/22] MIPS/Xlp/MSI: Use MSI chip framework to configure MSI/MSI-X irq Date: Fri, 26 Sep 2014 10:13:21 +0800 Message-ID: <5424CBC1.8080702@huawei.com> References: <1411614872-4009-1-git-send-email-wangyijing@huawei.com> <1411614872-4009-15-git-send-email-wangyijing@huawei.com> <20140925073608.GK12423@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from szxga03-in.huawei.com ([119.145.14.66]:29316 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752942AbaIZCNm (ORCPT ); Thu, 25 Sep 2014 22:13:42 -0400 In-Reply-To: <20140925073608.GK12423@ulmo> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Thierry Reding Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Xinwei Hu , Wuyun , linux-arm-kernel@lists.infradead.org, Russell King , linux-arch@vger.kernel.org, arnab.basu@freescale.com, Bharat.Bhushan@freescale.com, x86@kernel.org, Arnd Bergmann , Thomas Gleixner , Konrad Rzeszutek Wilk , xen-devel@lists.xenproject.org, Joerg Roedel , iommu@lists.linux-foundation.org, linux-mips@linux-mips.org, Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Sebastian Ott , Tony Luck , linux-ia64@vger.kernel.org, "David S. Miller" , sparclinux@vger.ke On 2014/9/25 15:36, Thierry Reding wrote: > On Thu, Sep 25, 2014 at 11:14:24AM +0800, Yijing Wang wrote: >> Use MSI chip framework instead of arch MSI functions to configure >> MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. > > Nit: s/irq/IRQ/ in the above. > >> Signed-off-by: Yijing Wang >> --- >> arch/mips/pci/msi-xlp.c | 14 ++++++++++++-- >> 1 files changed, 12 insertions(+), 2 deletions(-) >> >> diff --git a/arch/mips/pci/msi-xlp.c b/arch/mips/pci/msi-xlp.c >> index e469dc7..6b791ef 100644 >> --- a/arch/mips/pci/msi-xlp.c >> +++ b/arch/mips/pci/msi-xlp.c >> @@ -245,7 +245,7 @@ static struct irq_chip xlp_msix_chip = { >> .irq_unmask = unmask_msi_irq, >> }; >> >> -void arch_teardown_msi_irq(unsigned int irq) >> +void xlp_teardown_msi_irq(unsigned int irq) > > Should this not be static now as well? Yes, Will update. > > Thierry > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from szxga03-in.huawei.com ([119.145.14.66]:29316 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752942AbaIZCNm (ORCPT ); Thu, 25 Sep 2014 22:13:42 -0400 Message-ID: <5424CBC1.8080702@huawei.com> Date: Fri, 26 Sep 2014 10:13:21 +0800 From: Yijing Wang MIME-Version: 1.0 Subject: Re: [PATCH v2 14/22] MIPS/Xlp/MSI: Use MSI chip framework to configure MSI/MSI-X irq References: <1411614872-4009-1-git-send-email-wangyijing@huawei.com> <1411614872-4009-15-git-send-email-wangyijing@huawei.com> <20140925073608.GK12423@ulmo> In-Reply-To: <20140925073608.GK12423@ulmo> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Thierry Reding Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Xinwei Hu , Wuyun , linux-arm-kernel@lists.infradead.org, Russell King , linux-arch@vger.kernel.org, arnab.basu@freescale.com, Bharat.Bhushan@freescale.com, x86@kernel.org, Arnd Bergmann , Thomas Gleixner , Konrad Rzeszutek Wilk , xen-devel@lists.xenproject.org, Joerg Roedel , iommu@lists.linux-foundation.org, linux-mips@linux-mips.org, Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Sebastian Ott , Tony Luck , linux-ia64@vger.kernel.org, "David S. Miller" , sparclinux@vger.kernel.org, Chris Metcalf , Ralf Baechle , Lucas Stach , David Vrabel , Sergei Shtylyov , Michael Ellerman , Thomas Petazzoni Message-ID: <20140926021321.5rdkHeSIvnf-cnOHF4D427LsgYPu7A0-8WBBkqTydTc@z> On 2014/9/25 15:36, Thierry Reding wrote: > On Thu, Sep 25, 2014 at 11:14:24AM +0800, Yijing Wang wrote: >> Use MSI chip framework instead of arch MSI functions to configure >> MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. > > Nit: s/irq/IRQ/ in the above. > >> Signed-off-by: Yijing Wang >> --- >> arch/mips/pci/msi-xlp.c | 14 ++++++++++++-- >> 1 files changed, 12 insertions(+), 2 deletions(-) >> >> diff --git a/arch/mips/pci/msi-xlp.c b/arch/mips/pci/msi-xlp.c >> index e469dc7..6b791ef 100644 >> --- a/arch/mips/pci/msi-xlp.c >> +++ b/arch/mips/pci/msi-xlp.c >> @@ -245,7 +245,7 @@ static struct irq_chip xlp_msix_chip = { >> .irq_unmask = unmask_msi_irq, >> }; >> >> -void arch_teardown_msi_irq(unsigned int irq) >> +void xlp_teardown_msi_irq(unsigned int irq) > > Should this not be static now as well? Yes, Will update. > > Thierry > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yijing Wang Date: Fri, 26 Sep 2014 02:13:21 +0000 Subject: Re: [PATCH v2 14/22] MIPS/Xlp/MSI: Use MSI chip framework to configure MSI/MSI-X irq Message-Id: <5424CBC1.8080702@huawei.com> List-Id: References: <1411614872-4009-1-git-send-email-wangyijing@huawei.com> <1411614872-4009-15-git-send-email-wangyijing@huawei.com> <20140925073608.GK12423@ulmo> In-Reply-To: <20140925073608.GK12423@ulmo> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Thierry Reding Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Xinwei Hu , Wuyun , linux-arm-kernel@lists.infradead.org, Russell King , linux-arch@vger.kernel.org, arnab.basu@freescale.com, Bharat.Bhushan@freescale.com, x86@kernel.org, Arnd Bergmann , Thomas Gleixner , Konrad Rzeszutek Wilk , xen-devel@lists.xenproject.org, Joerg Roedel , iommu@lists.linux-foundation.org, linux-mips@linux-mips.org, Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Sebastian Ott , Tony Luck , linux-ia64@vger.kernel.org, "David S. Miller" , sparclinux@vger.kernel.org, Chris Metcalf , Ralf Baechle , Lucas Stach , David Vrabel , Sergei Shtylyov , Michael Ellerman , Thomas Petazzoni On 2014/9/25 15:36, Thierry Reding wrote: > On Thu, Sep 25, 2014 at 11:14:24AM +0800, Yijing Wang wrote: >> Use MSI chip framework instead of arch MSI functions to configure >> MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. > > Nit: s/irq/IRQ/ in the above. > >> Signed-off-by: Yijing Wang >> --- >> arch/mips/pci/msi-xlp.c | 14 ++++++++++++-- >> 1 files changed, 12 insertions(+), 2 deletions(-) >> >> diff --git a/arch/mips/pci/msi-xlp.c b/arch/mips/pci/msi-xlp.c >> index e469dc7..6b791ef 100644 >> --- a/arch/mips/pci/msi-xlp.c >> +++ b/arch/mips/pci/msi-xlp.c >> @@ -245,7 +245,7 @@ static struct irq_chip xlp_msix_chip = { >> .irq_unmask = unmask_msi_irq, >> }; >> >> -void arch_teardown_msi_irq(unsigned int irq) >> +void xlp_teardown_msi_irq(unsigned int irq) > > Should this not be static now as well? Yes, Will update. > > Thierry > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 26 Sep 2014 04:14:14 +0200 (CEST) Received: from szxga03-in.huawei.com ([119.145.14.66]:30874 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27008039AbaIZCOJFq0bP (ORCPT ); Fri, 26 Sep 2014 04:14:09 +0200 Received: from 172.24.2.119 (EHLO szxeml460-hub.china.huawei.com) ([172.24.2.119]) by szxrg03-dlp.huawei.com (MOS 4.4.3-GA FastPath queued) with ESMTP id AUW11416; Fri, 26 Sep 2014 10:13:38 +0800 (CST) Received: from [127.0.0.1] (10.177.27.212) by szxeml460-hub.china.huawei.com (10.82.67.203) with Microsoft SMTP Server id 14.3.158.1; Fri, 26 Sep 2014 10:13:29 +0800 Message-ID: <5424CBC1.8080702@huawei.com> Date: Fri, 26 Sep 2014 10:13:21 +0800 From: Yijing Wang User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Thierry Reding CC: Bjorn Helgaas , , , Xinwei Hu , Wuyun , , Russell King , , , , , Arnd Bergmann , Thomas Gleixner , "Konrad Rzeszutek Wilk" , , Joerg Roedel , , , Benjamin Herrenschmidt , , , Sebastian Ott , "Tony Luck" , , "David S. Miller" , , Chris Metcalf , Ralf Baechle , Lucas Stach , David Vrabel , "Sergei Shtylyov" , Michael Ellerman , Thomas Petazzoni Subject: Re: [PATCH v2 14/22] MIPS/Xlp/MSI: Use MSI chip framework to configure MSI/MSI-X irq References: <1411614872-4009-1-git-send-email-wangyijing@huawei.com> <1411614872-4009-15-git-send-email-wangyijing@huawei.com> <20140925073608.GK12423@ulmo> In-Reply-To: <20140925073608.GK12423@ulmo> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.27.212] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.5424CBD2.00BE,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: a1308cbcf4bde9ccfe842d6583a5c96c Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 42824 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: wangyijing@huawei.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 2014/9/25 15:36, Thierry Reding wrote: > On Thu, Sep 25, 2014 at 11:14:24AM +0800, Yijing Wang wrote: >> Use MSI chip framework instead of arch MSI functions to configure >> MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. > > Nit: s/irq/IRQ/ in the above. > >> Signed-off-by: Yijing Wang >> --- >> arch/mips/pci/msi-xlp.c | 14 ++++++++++++-- >> 1 files changed, 12 insertions(+), 2 deletions(-) >> >> diff --git a/arch/mips/pci/msi-xlp.c b/arch/mips/pci/msi-xlp.c >> index e469dc7..6b791ef 100644 >> --- a/arch/mips/pci/msi-xlp.c >> +++ b/arch/mips/pci/msi-xlp.c >> @@ -245,7 +245,7 @@ static struct irq_chip xlp_msix_chip = { >> .irq_unmask = unmask_msi_irq, >> }; >> >> -void arch_teardown_msi_irq(unsigned int irq) >> +void xlp_teardown_msi_irq(unsigned int irq) > > Should this not be static now as well? Yes, Will update. > > Thierry > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [119.145.14.66]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FDDB1A0AE1 for ; Fri, 26 Sep 2014 12:14:12 +1000 (EST) Message-ID: <5424CBC1.8080702@huawei.com> Date: Fri, 26 Sep 2014 10:13:21 +0800 From: Yijing Wang MIME-Version: 1.0 To: Thierry Reding Subject: Re: [PATCH v2 14/22] MIPS/Xlp/MSI: Use MSI chip framework to configure MSI/MSI-X irq References: <1411614872-4009-1-git-send-email-wangyijing@huawei.com> <1411614872-4009-15-git-send-email-wangyijing@huawei.com> <20140925073608.GK12423@ulmo> In-Reply-To: <20140925073608.GK12423@ulmo> Content-Type: text/plain; charset="ISO-8859-1" Cc: linux-mips@linux-mips.org, linux-ia64@vger.kernel.org, linux-pci@vger.kernel.org, Bharat.Bhushan@freescale.com, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Russell King , Joerg Roedel , x86@kernel.org, Sebastian Ott , xen-devel@lists.xenproject.org, arnab.basu@freescale.com, Arnd Bergmann , Konrad Rzeszutek Wilk , Chris Metcalf , Bjorn Helgaas , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Thomas Petazzoni , Xinwei Hu , Tony Luck , Sergei Shtylyov , linux-kernel@vger.kernel.org, Ralf Baechle , iommu@lists.linux-foundation.org, David Vrabel , Wuyun , linuxppc-dev@lists.ozlabs.org, "David S. Miller" , Lucas Stach List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 2014/9/25 15:36, Thierry Reding wrote: > On Thu, Sep 25, 2014 at 11:14:24AM +0800, Yijing Wang wrote: >> Use MSI chip framework instead of arch MSI functions to configure >> MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. > > Nit: s/irq/IRQ/ in the above. > >> Signed-off-by: Yijing Wang >> --- >> arch/mips/pci/msi-xlp.c | 14 ++++++++++++-- >> 1 files changed, 12 insertions(+), 2 deletions(-) >> >> diff --git a/arch/mips/pci/msi-xlp.c b/arch/mips/pci/msi-xlp.c >> index e469dc7..6b791ef 100644 >> --- a/arch/mips/pci/msi-xlp.c >> +++ b/arch/mips/pci/msi-xlp.c >> @@ -245,7 +245,7 @@ static struct irq_chip xlp_msix_chip = { >> .irq_unmask = unmask_msi_irq, >> }; >> >> -void arch_teardown_msi_irq(unsigned int irq) >> +void xlp_teardown_msi_irq(unsigned int irq) > > Should this not be static now as well? Yes, Will update. > > Thierry > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yijing Wang Date: Fri, 26 Sep 2014 02:13:21 +0000 Subject: Re: [PATCH v2 14/22] MIPS/Xlp/MSI: Use MSI chip framework to configure MSI/MSI-X irq Message-Id: <5424CBC1.8080702@huawei.com> List-Id: References: <1411614872-4009-1-git-send-email-wangyijing@huawei.com> <1411614872-4009-15-git-send-email-wangyijing@huawei.com> <20140925073608.GK12423@ulmo> In-Reply-To: <20140925073608.GK12423@ulmo> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Thierry Reding Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Xinwei Hu , Wuyun , linux-arm-kernel@lists.infradead.org, Russell King , linux-arch@vger.kernel.org, arnab.basu@freescale.com, Bharat.Bhushan@freescale.com, x86@kernel.org, Arnd Bergmann , Thomas Gleixner , Konrad Rzeszutek Wilk , xen-devel@lists.xenproject.org, Joerg Roedel , iommu@lists.linux-foundation.org, linux-mips@linux-mips.org, Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Sebastian Ott , Tony Luck , linux-ia64@vger.kernel.org, "David S. Miller" , sparclinux@vger.ke On 2014/9/25 15:36, Thierry Reding wrote: > On Thu, Sep 25, 2014 at 11:14:24AM +0800, Yijing Wang wrote: >> Use MSI chip framework instead of arch MSI functions to configure >> MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. > > Nit: s/irq/IRQ/ in the above. > >> Signed-off-by: Yijing Wang >> --- >> arch/mips/pci/msi-xlp.c | 14 ++++++++++++-- >> 1 files changed, 12 insertions(+), 2 deletions(-) >> >> diff --git a/arch/mips/pci/msi-xlp.c b/arch/mips/pci/msi-xlp.c >> index e469dc7..6b791ef 100644 >> --- a/arch/mips/pci/msi-xlp.c >> +++ b/arch/mips/pci/msi-xlp.c >> @@ -245,7 +245,7 @@ static struct irq_chip xlp_msix_chip = { >> .irq_unmask = unmask_msi_irq, >> }; >> >> -void arch_teardown_msi_irq(unsigned int irq) >> +void xlp_teardown_msi_irq(unsigned int irq) > > Should this not be static now as well? Yes, Will update. > > Thierry > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 From: wangyijing@huawei.com (Yijing Wang) Date: Fri, 26 Sep 2014 10:13:21 +0800 Subject: [PATCH v2 14/22] MIPS/Xlp/MSI: Use MSI chip framework to configure MSI/MSI-X irq In-Reply-To: <20140925073608.GK12423@ulmo> References: <1411614872-4009-1-git-send-email-wangyijing@huawei.com> <1411614872-4009-15-git-send-email-wangyijing@huawei.com> <20140925073608.GK12423@ulmo> Message-ID: <5424CBC1.8080702@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2014/9/25 15:36, Thierry Reding wrote: > On Thu, Sep 25, 2014 at 11:14:24AM +0800, Yijing Wang wrote: >> Use MSI chip framework instead of arch MSI functions to configure >> MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. > > Nit: s/irq/IRQ/ in the above. > >> Signed-off-by: Yijing Wang >> --- >> arch/mips/pci/msi-xlp.c | 14 ++++++++++++-- >> 1 files changed, 12 insertions(+), 2 deletions(-) >> >> diff --git a/arch/mips/pci/msi-xlp.c b/arch/mips/pci/msi-xlp.c >> index e469dc7..6b791ef 100644 >> --- a/arch/mips/pci/msi-xlp.c >> +++ b/arch/mips/pci/msi-xlp.c >> @@ -245,7 +245,7 @@ static struct irq_chip xlp_msix_chip = { >> .irq_unmask = unmask_msi_irq, >> }; >> >> -void arch_teardown_msi_irq(unsigned int irq) >> +void xlp_teardown_msi_irq(unsigned int irq) > > Should this not be static now as well? Yes, Will update. > > Thierry > -- Thanks! Yijing