From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yijing Wang Subject: Re: [PATCH v2 06/22] PCI/MSI: Introduce weak arch_find_msi_chip() to find MSI chip Date: Fri, 26 Sep 2014 10:33:24 +0800 Message-ID: <5424D074.60102@huawei.com> References: <1411614872-4009-1-git-send-email-wangyijing@huawei.com> <1411614872-4009-7-git-send-email-wangyijing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from szxga02-in.huawei.com ([119.145.14.65]:7739 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753041AbaIZCeJ (ORCPT ); Thu, 25 Sep 2014 22:34:09 -0400 In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Thomas Gleixner Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Xinwei Hu , Wuyun , linux-arm-kernel@lists.infradead.org, Russell King , linux-arch@vger.kernel.org, arnab.basu@freescale.com, Bharat.Bhushan@freescale.com, x86@kernel.org, Arnd Bergmann , Konrad Rzeszutek Wilk , xen-devel@lists.xenproject.org, Joerg Roedel , iommu@lists.linux-foundation.org, linux-mips@linux-mips.org, Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Sebastian Ott , Tony Luck , linux-ia64@vger.kernel.org, "David S. Miller" , sparclinux@vger.kernel.org, Chris Metcalf On 2014/9/25 18:38, Thomas Gleixner wrote: > On Thu, 25 Sep 2014, Yijing Wang wrote: > >> Introduce weak arch_find_msi_chip() to find the match msi_chip. >> Currently, MSI chip associates pci bus to msi_chip. Because in >> ARM platform, there may be more than one MSI controller in system. >> Associate pci bus to msi_chip help pci device to find the match >> msi_chip and setup MSI/MSI-X irq correctly. But in other platform, >> like in x86. we only need one MSI chip, because all device use >> the same MSI address/data and irq etc. So it's no need to associate >> pci bus to MSI chip, just use a arch function, arch_find_msi_chip() >> to return the MSI chip for simplicity. The default weak >> arch_find_msi_chip() used in ARM platform, find the MSI chip >> by pci bus. > > This is really backwards. On one hand you try to get rid of the weak > arch functions zoo and then you invent new ones for no good > reason. Why can't x86 store the chip in the pci bus? Hi Thomas, I introduced this weak function , because I thought all platforms except arm always have only one msi chip, and I hoped to provide a simplest solution, less code changes. I consider several solutions to associate msi chip and PCI device. In my reply to Thierry in first reply, http://marc.info/?l=linux-pci&m=141169658208255&w=2 Could you give me some advices ? Thanks! Yijing. > > Looking deeper, I'm questioning the whole notion of different > msi_chips. Are this really different MSI controllers with a different > feature set or are this defacto multiple instances of the same > controller which just need a different data set? > > Thanks, > > tglx > > . > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from szxga02-in.huawei.com ([119.145.14.65]:7739 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753041AbaIZCeJ (ORCPT ); Thu, 25 Sep 2014 22:34:09 -0400 Message-ID: <5424D074.60102@huawei.com> Date: Fri, 26 Sep 2014 10:33:24 +0800 From: Yijing Wang MIME-Version: 1.0 Subject: Re: [PATCH v2 06/22] PCI/MSI: Introduce weak arch_find_msi_chip() to find MSI chip References: <1411614872-4009-1-git-send-email-wangyijing@huawei.com> <1411614872-4009-7-git-send-email-wangyijing@huawei.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Thomas Gleixner Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Xinwei Hu , Wuyun , linux-arm-kernel@lists.infradead.org, Russell King , linux-arch@vger.kernel.org, arnab.basu@freescale.com, Bharat.Bhushan@freescale.com, x86@kernel.org, Arnd Bergmann , Konrad Rzeszutek Wilk , xen-devel@lists.xenproject.org, Joerg Roedel , iommu@lists.linux-foundation.org, linux-mips@linux-mips.org, Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Sebastian Ott , Tony Luck , linux-ia64@vger.kernel.org, "David S. Miller" , sparclinux@vger.kernel.org, Chris Metcalf , Ralf Baechle , Lucas Stach , David Vrabel , Sergei Shtylyov , Michael Ellerman , Thierry Reding , Thomas Petazzoni Message-ID: <20140926023324.ehpOutRlC6y0wopnCQOmVPQxTJqRuL23UQGYnmAco2o@z> On 2014/9/25 18:38, Thomas Gleixner wrote: > On Thu, 25 Sep 2014, Yijing Wang wrote: > >> Introduce weak arch_find_msi_chip() to find the match msi_chip. >> Currently, MSI chip associates pci bus to msi_chip. Because in >> ARM platform, there may be more than one MSI controller in system. >> Associate pci bus to msi_chip help pci device to find the match >> msi_chip and setup MSI/MSI-X irq correctly. But in other platform, >> like in x86. we only need one MSI chip, because all device use >> the same MSI address/data and irq etc. So it's no need to associate >> pci bus to MSI chip, just use a arch function, arch_find_msi_chip() >> to return the MSI chip for simplicity. The default weak >> arch_find_msi_chip() used in ARM platform, find the MSI chip >> by pci bus. > > This is really backwards. On one hand you try to get rid of the weak > arch functions zoo and then you invent new ones for no good > reason. Why can't x86 store the chip in the pci bus? Hi Thomas, I introduced this weak function , because I thought all platforms except arm always have only one msi chip, and I hoped to provide a simplest solution, less code changes. I consider several solutions to associate msi chip and PCI device. In my reply to Thierry in first reply, http://marc.info/?l=linux-pci&m=141169658208255&w=2 Could you give me some advices ? Thanks! Yijing. > > Looking deeper, I'm questioning the whole notion of different > msi_chips. Are this really different MSI controllers with a different > feature set or are this defacto multiple instances of the same > controller which just need a different data set? > > Thanks, > > tglx > > . > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yijing Wang Date: Fri, 26 Sep 2014 02:33:24 +0000 Subject: Re: [PATCH v2 06/22] PCI/MSI: Introduce weak arch_find_msi_chip() to find MSI chip Message-Id: <5424D074.60102@huawei.com> List-Id: References: <1411614872-4009-1-git-send-email-wangyijing@huawei.com> <1411614872-4009-7-git-send-email-wangyijing@huawei.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Thomas Gleixner Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Xinwei Hu , Wuyun , linux-arm-kernel@lists.infradead.org, Russell King , linux-arch@vger.kernel.org, arnab.basu@freescale.com, Bharat.Bhushan@freescale.com, x86@kernel.org, Arnd Bergmann , Konrad Rzeszutek Wilk , xen-devel@lists.xenproject.org, Joerg Roedel , iommu@lists.linux-foundation.org, linux-mips@linux-mips.org, Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Sebastian Ott , Tony Luck , linux-ia64@vger.kernel.org, "David S. Miller" , sparclinux@vger.kernel.org, Chris Metcalf , Ralf Baechle , Lucas Stach , David Vrabel , Sergei Shtylyov , Michael Ellerman , Thierry Reding , Thomas Petazzoni On 2014/9/25 18:38, Thomas Gleixner wrote: > On Thu, 25 Sep 2014, Yijing Wang wrote: > >> Introduce weak arch_find_msi_chip() to find the match msi_chip. >> Currently, MSI chip associates pci bus to msi_chip. Because in >> ARM platform, there may be more than one MSI controller in system. >> Associate pci bus to msi_chip help pci device to find the match >> msi_chip and setup MSI/MSI-X irq correctly. But in other platform, >> like in x86. we only need one MSI chip, because all device use >> the same MSI address/data and irq etc. So it's no need to associate >> pci bus to MSI chip, just use a arch function, arch_find_msi_chip() >> to return the MSI chip for simplicity. The default weak >> arch_find_msi_chip() used in ARM platform, find the MSI chip >> by pci bus. > > This is really backwards. On one hand you try to get rid of the weak > arch functions zoo and then you invent new ones for no good > reason. Why can't x86 store the chip in the pci bus? Hi Thomas, I introduced this weak function , because I thought all platforms except arm always have only one msi chip, and I hoped to provide a simplest solution, less code changes. I consider several solutions to associate msi chip and PCI device. In my reply to Thierry in first reply, http://marc.info/?l=linux-pci&m1169658208255&w=2 Could you give me some advices ? Thanks! Yijing. > > Looking deeper, I'm questioning the whole notion of different > msi_chips. Are this really different MSI controllers with a different > feature set or are this defacto multiple instances of the same > controller which just need a different data set? > > Thanks, > > tglx > > . > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 26 Sep 2014 04:35:07 +0200 (CEST) Received: from szxga02-in.huawei.com ([119.145.14.65]:49234 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27006668AbaIZCfEFZKA0 (ORCPT ); Fri, 26 Sep 2014 04:35:04 +0200 Received: from 172.24.2.119 (EHLO szxeml421-hub.china.huawei.com) ([172.24.2.119]) by szxrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id BZZ13705; Fri, 26 Sep 2014 10:33:40 +0800 (CST) Received: from [127.0.0.1] (10.177.27.212) by szxeml421-hub.china.huawei.com (10.82.67.160) with Microsoft SMTP Server id 14.3.158.1; Fri, 26 Sep 2014 10:33:31 +0800 Message-ID: <5424D074.60102@huawei.com> Date: Fri, 26 Sep 2014 10:33:24 +0800 From: Yijing Wang User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Thomas Gleixner CC: Bjorn Helgaas , , , Xinwei Hu , Wuyun , , Russell King , , , , , Arnd Bergmann , Konrad Rzeszutek Wilk , , Joerg Roedel , , , Benjamin Herrenschmidt , , , Sebastian Ott , "Tony Luck" , , "David S. Miller" , , Chris Metcalf , Ralf Baechle , Lucas Stach , David Vrabel , "Sergei Shtylyov" , Michael Ellerman , Thierry Reding , "Thomas Petazzoni" Subject: Re: [PATCH v2 06/22] PCI/MSI: Introduce weak arch_find_msi_chip() to find MSI chip References: <1411614872-4009-1-git-send-email-wangyijing@huawei.com> <1411614872-4009-7-git-send-email-wangyijing@huawei.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.27.212] X-CFilter-Loop: Reflected Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 42828 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: wangyijing@huawei.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 2014/9/25 18:38, Thomas Gleixner wrote: > On Thu, 25 Sep 2014, Yijing Wang wrote: > >> Introduce weak arch_find_msi_chip() to find the match msi_chip. >> Currently, MSI chip associates pci bus to msi_chip. Because in >> ARM platform, there may be more than one MSI controller in system. >> Associate pci bus to msi_chip help pci device to find the match >> msi_chip and setup MSI/MSI-X irq correctly. But in other platform, >> like in x86. we only need one MSI chip, because all device use >> the same MSI address/data and irq etc. So it's no need to associate >> pci bus to MSI chip, just use a arch function, arch_find_msi_chip() >> to return the MSI chip for simplicity. The default weak >> arch_find_msi_chip() used in ARM platform, find the MSI chip >> by pci bus. > > This is really backwards. On one hand you try to get rid of the weak > arch functions zoo and then you invent new ones for no good > reason. Why can't x86 store the chip in the pci bus? Hi Thomas, I introduced this weak function , because I thought all platforms except arm always have only one msi chip, and I hoped to provide a simplest solution, less code changes. I consider several solutions to associate msi chip and PCI device. In my reply to Thierry in first reply, http://marc.info/?l=linux-pci&m=141169658208255&w=2 Could you give me some advices ? Thanks! Yijing. > > Looking deeper, I'm questioning the whole notion of different > msi_chips. Are this really different MSI controllers with a different > feature set or are this defacto multiple instances of the same > controller which just need a different data set? > > Thanks, > > tglx > > . > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [119.145.14.65]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 7325E1A01DB for ; Fri, 26 Sep 2014 12:34:20 +1000 (EST) Message-ID: <5424D074.60102@huawei.com> Date: Fri, 26 Sep 2014 10:33:24 +0800 From: Yijing Wang MIME-Version: 1.0 To: Thomas Gleixner Subject: Re: [PATCH v2 06/22] PCI/MSI: Introduce weak arch_find_msi_chip() to find MSI chip References: <1411614872-4009-1-git-send-email-wangyijing@huawei.com> <1411614872-4009-7-git-send-email-wangyijing@huawei.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Cc: linux-mips@linux-mips.org, linux-ia64@vger.kernel.org, linux-pci@vger.kernel.org, Bharat.Bhushan@freescale.com, Thierry Reding , sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Russell King , Joerg Roedel , x86@kernel.org, Sebastian Ott , xen-devel@lists.xenproject.org, arnab.basu@freescale.com, Arnd Bergmann , Konrad Rzeszutek Wilk , Chris Metcalf , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org, Thomas Petazzoni , Xinwei Hu , Tony Luck , Sergei Shtylyov , linux-kernel@vger.kernel.org, Ralf Baechle , iommu@lists.linux-foundation.org, David Vrabel , Wuyun , linuxppc-dev@lists.ozlabs.org, "David S. Miller" , Lucas Stach List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 2014/9/25 18:38, Thomas Gleixner wrote: > On Thu, 25 Sep 2014, Yijing Wang wrote: > >> Introduce weak arch_find_msi_chip() to find the match msi_chip. >> Currently, MSI chip associates pci bus to msi_chip. Because in >> ARM platform, there may be more than one MSI controller in system. >> Associate pci bus to msi_chip help pci device to find the match >> msi_chip and setup MSI/MSI-X irq correctly. But in other platform, >> like in x86. we only need one MSI chip, because all device use >> the same MSI address/data and irq etc. So it's no need to associate >> pci bus to MSI chip, just use a arch function, arch_find_msi_chip() >> to return the MSI chip for simplicity. The default weak >> arch_find_msi_chip() used in ARM platform, find the MSI chip >> by pci bus. > > This is really backwards. On one hand you try to get rid of the weak > arch functions zoo and then you invent new ones for no good > reason. Why can't x86 store the chip in the pci bus? Hi Thomas, I introduced this weak function , because I thought all platforms except arm always have only one msi chip, and I hoped to provide a simplest solution, less code changes. I consider several solutions to associate msi chip and PCI device. In my reply to Thierry in first reply, http://marc.info/?l=linux-pci&m=141169658208255&w=2 Could you give me some advices ? Thanks! Yijing. > > Looking deeper, I'm questioning the whole notion of different > msi_chips. Are this really different MSI controllers with a different > feature set or are this defacto multiple instances of the same > controller which just need a different data set? > > Thanks, > > tglx > > . > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yijing Wang Date: Fri, 26 Sep 2014 02:33:24 +0000 Subject: Re: [PATCH v2 06/22] PCI/MSI: Introduce weak arch_find_msi_chip() to find MSI chip Message-Id: <5424D074.60102@huawei.com> List-Id: References: <1411614872-4009-1-git-send-email-wangyijing@huawei.com> <1411614872-4009-7-git-send-email-wangyijing@huawei.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Thomas Gleixner Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Xinwei Hu , Wuyun , linux-arm-kernel@lists.infradead.org, Russell King , linux-arch@vger.kernel.org, arnab.basu@freescale.com, Bharat.Bhushan@freescale.com, x86@kernel.org, Arnd Bergmann , Konrad Rzeszutek Wilk , xen-devel@lists.xenproject.org, Joerg Roedel , iommu@lists.linux-foundation.org, linux-mips@linux-mips.org, Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Sebastian Ott , Tony Luck , linux-ia64@vger.kernel.org, "David S. Miller" , sparclinux@vger.kernel.org, Chris Metcalf On 2014/9/25 18:38, Thomas Gleixner wrote: > On Thu, 25 Sep 2014, Yijing Wang wrote: > >> Introduce weak arch_find_msi_chip() to find the match msi_chip. >> Currently, MSI chip associates pci bus to msi_chip. Because in >> ARM platform, there may be more than one MSI controller in system. >> Associate pci bus to msi_chip help pci device to find the match >> msi_chip and setup MSI/MSI-X irq correctly. But in other platform, >> like in x86. we only need one MSI chip, because all device use >> the same MSI address/data and irq etc. So it's no need to associate >> pci bus to MSI chip, just use a arch function, arch_find_msi_chip() >> to return the MSI chip for simplicity. The default weak >> arch_find_msi_chip() used in ARM platform, find the MSI chip >> by pci bus. > > This is really backwards. On one hand you try to get rid of the weak > arch functions zoo and then you invent new ones for no good > reason. Why can't x86 store the chip in the pci bus? Hi Thomas, I introduced this weak function , because I thought all platforms except arm always have only one msi chip, and I hoped to provide a simplest solution, less code changes. I consider several solutions to associate msi chip and PCI device. In my reply to Thierry in first reply, http://marc.info/?l=linux-pci&m1169658208255&w=2 Could you give me some advices ? Thanks! Yijing. > > Looking deeper, I'm questioning the whole notion of different > msi_chips. Are this really different MSI controllers with a different > feature set or are this defacto multiple instances of the same > controller which just need a different data set? > > Thanks, > > tglx > > . > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 From: wangyijing@huawei.com (Yijing Wang) Date: Fri, 26 Sep 2014 10:33:24 +0800 Subject: [PATCH v2 06/22] PCI/MSI: Introduce weak arch_find_msi_chip() to find MSI chip In-Reply-To: References: <1411614872-4009-1-git-send-email-wangyijing@huawei.com> <1411614872-4009-7-git-send-email-wangyijing@huawei.com> Message-ID: <5424D074.60102@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2014/9/25 18:38, Thomas Gleixner wrote: > On Thu, 25 Sep 2014, Yijing Wang wrote: > >> Introduce weak arch_find_msi_chip() to find the match msi_chip. >> Currently, MSI chip associates pci bus to msi_chip. Because in >> ARM platform, there may be more than one MSI controller in system. >> Associate pci bus to msi_chip help pci device to find the match >> msi_chip and setup MSI/MSI-X irq correctly. But in other platform, >> like in x86. we only need one MSI chip, because all device use >> the same MSI address/data and irq etc. So it's no need to associate >> pci bus to MSI chip, just use a arch function, arch_find_msi_chip() >> to return the MSI chip for simplicity. The default weak >> arch_find_msi_chip() used in ARM platform, find the MSI chip >> by pci bus. > > This is really backwards. On one hand you try to get rid of the weak > arch functions zoo and then you invent new ones for no good > reason. Why can't x86 store the chip in the pci bus? Hi Thomas, I introduced this weak function , because I thought all platforms except arm always have only one msi chip, and I hoped to provide a simplest solution, less code changes. I consider several solutions to associate msi chip and PCI device. In my reply to Thierry in first reply, http://marc.info/?l=linux-pci&m=141169658208255&w=2 Could you give me some advices ? Thanks! Yijing. > > Looking deeper, I'm questioning the whole notion of different > msi_chips. Are this really different MSI controllers with a different > feature set or are this defacto multiple instances of the same > controller which just need a different data set? > > Thanks, > > tglx > > . > -- Thanks! Yijing