From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52688)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1XXTY8-00074q-8x
	for qemu-devel@nongnu.org; Fri, 26 Sep 2014 07:19:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1XXTY2-0002e5-C2
	for qemu-devel@nongnu.org; Fri, 26 Sep 2014 07:18:56 -0400
Received: from cantor2.suse.de ([195.135.220.15]:44474 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1XXTY2-0002bG-60
	for qemu-devel@nongnu.org; Fri, 26 Sep 2014 07:18:50 -0400
Message-ID: <54254B93.1070205@suse.de>
Date: Fri, 26 Sep 2014 13:18:43 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1411474456-12226-1-git-send-email-borntraeger@de.ibm.com>
	<1411474456-12226-4-git-send-email-borntraeger@de.ibm.com>
	<542541B6.1000009@suse.de> <542544A2.6030600@de.ibm.com>
In-Reply-To: <542544A2.6030600@de.ibm.com>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PULL 3/3] s390x/css: catch ccw sequence errors
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christian Borntraeger <borntraeger@de.ibm.com>, Peter Maydell <peter.maydell@linaro.org>, Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Jens Freimann <jfrei@linux.vnet.ibm.com>, Richard Henderson <rth@twiddle.net>, qemu-devel <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>

Am 26.09.2014 um 12:49 schrieb Christian Borntraeger:
> On 09/26/2014 12:36 PM, Andreas F=E4rber wrote:
>=20
>>> @@ -1414,6 +1423,7 @@ int subch_device_load(SubchDev *s, QEMUFile *f)
>>>          s->id.ciw[i].count =3D qemu_get_be16(f);
>>>      }
>>>      s->ccw_fmt_1 =3D qemu_get_byte(f);
>>> +    s->ccw_no_data_cnt =3D qemu_get_byte(f);
>>>      return 0;
>>>  }
>>> =20
>>
>> You need to bump the version saved if you add fields (same as VMState)=
,
>> and on load you need to check the version for whether to load the fiel=
d
>> (or deny loading).
>=20
> Alex brough up the same thing. As the cpu migration code is not yet ups=
tream (in prep right now) we concluded that this is still ok.
>=20
> http://lists.gnu.org/archive/html/qemu-devel/2014-09/msg01094.html

You should justify that in each such commit message then.

However, the number space is large enough to bump the number each time
to avoid forgetting it later.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg