From: "Anton Ivanov (antivano)" <antivano@cisco.com>
To: Richard Weinberger <richard@nod.at>,
"anton.ivanov@kot-begemot.co.uk" <anton.ivanov@kot-begemot.co.uk>,
"user-mode-linux-devel@lists.sourceforge.net"
<user-mode-linux-devel@lists.sourceforge.net>
Cc: Daniel Walter <dwalter@google.com>
Subject: Re: [uml-devel] [PATCH] Fix for "occasional userspace process in D/Z state" bug
Date: Fri, 26 Sep 2014 12:35:01 +0000 [thread overview]
Message-ID: <54255D73.1030509@cisco.com> (raw)
In-Reply-To: <5425547C.1080002@nod.at>
On 26/09/14 12:56, Richard Weinberger wrote:
[snip]
> +#ifdef CONFIG_X86_32
> + alternative("lock; addl $0,0(%%esp)", "mfence", X86_FEATURE_XMM2);
> +#else
> + asm volatile("mfence":::"memory");
> +#endif
> Why not mb()?
> I'm not sure whether this fix is correct.
Looking at the actual defines that would work. I was originally looking
at asm-generic instead of x86/um/asm/barrier.h and the asm-generic
barrier() would have been insufficent.
x86/um/asm/barrier.h has literally the same define, so as you noted -
using mb() will have the same effect.
As far as is this fix correct or not - I do not know myself. I said it
when submitting it :)
It definitely fixes the problem - both the original (and extremely
difficult to reproduce) D|Z in the stock UML and the similar (and much
easier to reproduce) D|Z which you get with all the disk subsystem
improvement patches.
I will reissue it with mb() shortly.
A.
>
> Thanks,
> //richard
------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
next prev parent reply other threads:[~2014-09-26 12:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 11:49 [uml-devel] [PATCH] Fix for "occasional userspace process in D/Z state" bug anton.ivanov
2014-09-26 11:56 ` Richard Weinberger
2014-09-26 12:35 ` Anton Ivanov (antivano) [this message]
2014-09-28 8:15 ` Anton Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54255D73.1030509@cisco.com \
--to=antivano@cisco.com \
--cc=anton.ivanov@kot-begemot.co.uk \
--cc=dwalter@google.com \
--cc=richard@nod.at \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.