From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexander Graf <agraf@suse.de>, qemu-ppc@nongnu.org
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com,
eric.auger@linaro.org, qemu-devel@nongnu.org,
sean.stalley@intel.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH v3 5/7] sysbus: Add new platform bus helper device
Date: Fri, 26 Sep 2014 14:44:11 +0200 [thread overview]
Message-ID: <54255F9B.40800@redhat.com> (raw)
In-Reply-To: <54255B8E.7020500@suse.de>
Il 26/09/2014 14:26, Alexander Graf ha scritto:
>
> Are you sure? Imagine one sysbus device includes another. We only want
> to look at the region the lowest sysbus device exposes, no?
IIUC this function is used to build the device tree. Say you have 2
consecutive memory regions and the device tree requires separate "reg"
entries for them. But because they are consecutive (or perhaps because
you have a PCI version of the same device that sticks them in a single
BAR) you use a single MMIO area at the sysbus level.
In that case, you will use platform_bus_get_mmio_addr on the two inner
regions, not the outer one.
BTW, I think you will never have one sysbus device including another.
The contained device would be busless (similar to the "naked" 8250
device in hw/char/serial.c, except perhaps QOMified).
Paolo
next prev parent reply other threads:[~2014-09-26 12:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 15:22 [Qemu-devel] [PATCH v3 0/7] Dynamic sysbus device allocation support Alexander Graf
2014-09-24 15:22 ` [Qemu-devel] [PATCH v3 1/7] sysbus: Add dynamic sysbus device search Alexander Graf
2014-09-24 15:22 ` [Qemu-devel] [PATCH v3 2/7] sysbus: Make devices spawnable via -device Alexander Graf
2014-09-24 15:37 ` Paolo Bonzini
2014-09-25 13:17 ` [Qemu-devel] [PATCH v4 " Alexander Graf
2014-09-24 15:22 ` [Qemu-devel] [PATCH v3 3/7] sysbus: Expose IRQ enumeration helpers Alexander Graf
2014-09-24 15:22 ` [Qemu-devel] [PATCH v3 4/7] sysbus: Expose MMIO enumeration helper Alexander Graf
2014-09-24 15:22 ` [Qemu-devel] [PATCH v3 5/7] sysbus: Add new platform bus helper device Alexander Graf
2014-09-26 12:05 ` Paolo Bonzini
2014-09-26 12:26 ` Alexander Graf
2014-09-26 12:44 ` Paolo Bonzini [this message]
2014-09-29 8:24 ` Alexander Graf
2014-09-29 8:30 ` Paolo Bonzini
2014-09-24 15:22 ` [Qemu-devel] [PATCH v3 6/7] PPC: e500: Support dynamically spawned sysbus devices Alexander Graf
2014-09-24 15:22 ` [Qemu-devel] [PATCH v3 7/7] e500: Add support for eTSEC in device tree Alexander Graf
2014-09-24 15:40 ` [Qemu-devel] [PATCH v3 0/7] Dynamic sysbus device allocation support Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54255F9B.40800@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=eric.auger@linaro.org \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=sean.stalley@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.