All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dinh Nguyen <dinguyen@opensource.altera.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] usb: dwc2: Add driver for Synopsis DWC2 USB IP	block
Date: Fri, 26 Sep 2014 10:01:22 -0500	[thread overview]
Message-ID: <54257FC2.3080501@opensource.altera.com> (raw)
In-Reply-To: <201409260929.55462.marex@denx.de>

On 09/26/2014 02:29 AM, Marek Vasut wrote:
> On Tuesday, September 23, 2014 at 11:59:28 PM, Dinh Nguyen wrote:
> 
> 
> btw. please try to trim down the content of the patch when replying only to the 
> relevant part, so others don't have to look up the relevant bits among billions
> of lines of irrelevant stuff.
> 

Will do more snipping...
> [...]
> 
> 
>>> +#define DWC2_GUSBCFG_TX_END_DELAY			(1 << 28)
>>> +#define DWC2_GUSBCFG_TX_END_DELAY_OFFSET		28
>>
>> bits 29 and 30 of GUSBCFG are to Force Host and Device mode, respectively.
>> These bits may get used in the future.
> 
> That's good, what's their exact name please ?
> 

They should be:
#define DWC2_GUSBCFG_FORCEDEVMODE            (1 << 30)
#define DWC2_GUSBCFG_FORCEHOSTMODE           (1 << 29)

Also, for patch 1/3 and 2/3, I was able to test USB functionality on the
SoCFPGA devkit. So you can add:

Tested-by: Dinh Nguyen <dinguyen@opensource.altera.com>

Thanks,
Dinh

  reply	other threads:[~2014-09-26 15:01 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-21 13:13 [U-Boot] [PATCH 0/3] usb: dwc2: Add and enable DWC2 driver Marek Vasut
2014-09-21 13:13 ` [U-Boot] [PATCH 1/3] usb: dwc2: Add driver for Synopsis DWC2 USB IP block Marek Vasut
2014-09-22  9:40   ` Pavel Machek
2014-09-22 10:53     ` Marek Vasut
2014-09-30 11:57       ` Pavel Machek
2014-09-23 21:59   ` Dinh Nguyen
2014-09-26  7:29     ` Marek Vasut
2014-09-26 15:01       ` Dinh Nguyen [this message]
2014-09-26 15:59         ` Marek Vasut
2014-09-24  3:31   ` Stephen Warren
2014-09-24  9:25     ` Marek Vasut
2014-09-24 15:37     ` Stephen Warren
2014-09-24 17:47       ` Marek Vasut
2014-09-21 13:13 ` [U-Boot] [PATCH 2/3] arm: socfpga: config: Enable USB support Marek Vasut
2014-09-23 19:55   ` Dinh Nguyen
2014-09-23 20:16     ` Marek Vasut
2014-09-23 22:21     ` Dinh Nguyen
2014-09-23 23:36       ` Marek Vasut
2014-09-21 13:13 ` [U-Boot] [PATCH 3/3] arm: rpi: Enable USB support on RPi Marek Vasut
2014-09-29  7:02 ` [U-Boot] [PATCH 0/3] usb: dwc2: Add and enable DWC2 driver Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54257FC2.3080501@opensource.altera.com \
    --to=dinguyen@opensource.altera.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.