From: sudeep.holla@arm.com (Sudeep Holla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] perf tools: fix build breakage on arm and arm64 targets
Date: Fri, 26 Sep 2014 18:19:04 +0100 [thread overview]
Message-ID: <5425A008.2030901@arm.com> (raw)
In-Reply-To: <1411750918-25220-1-git-send-email-will.deacon@arm.com>
On 26/09/14 18:01, Will Deacon wrote:
> Attempting to build the perf tool on arm or arm64 targets results in the
> following failure:
>
> arch/arm/util/unwind-libunwind.c: In function ?libunwind__arch_reg_id?:
> arch/arm/util/unwind-libunwind.c:43:3: error: implicit declaration of function ?pr_err? [-Werror=implicit-function-declaration]
> pr_err("unwind: invalid reg id %d\n", regnum);
> ^
> This is due to commit 84f5d36f4866 ("perf tools: Move pr_* debug macros
> into debug object") moving the pr_* macros into a new header file, but
> failing to update architectures other than x86.
>
> This patch adds the missing includes, and fixes the build again.
>
For ARM64, we also need the patch[1] "perf tools: Fix arm64 build error"
which is already queued in linux-next.
Regards,
Sudeep
[1] https://lkml.org/lkml/2014/6/24/1024
WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com>
To: Will Deacon <will.deacon@arm.com>, "acme@redhat.com" <acme@redhat.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>, Jiri Olsa <jolsa@kernel.org>,
Jean Pihet <jean.pihet@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] perf tools: fix build breakage on arm and arm64 targets
Date: Fri, 26 Sep 2014 18:19:04 +0100 [thread overview]
Message-ID: <5425A008.2030901@arm.com> (raw)
In-Reply-To: <1411750918-25220-1-git-send-email-will.deacon@arm.com>
On 26/09/14 18:01, Will Deacon wrote:
> Attempting to build the perf tool on arm or arm64 targets results in the
> following failure:
>
> arch/arm/util/unwind-libunwind.c: In function ‘libunwind__arch_reg_id’:
> arch/arm/util/unwind-libunwind.c:43:3: error: implicit declaration of function ‘pr_err’ [-Werror=implicit-function-declaration]
> pr_err("unwind: invalid reg id %d\n", regnum);
> ^
> This is due to commit 84f5d36f4866 ("perf tools: Move pr_* debug macros
> into debug object") moving the pr_* macros into a new header file, but
> failing to update architectures other than x86.
>
> This patch adds the missing includes, and fixes the build again.
>
For ARM64, we also need the patch[1] "perf tools: Fix arm64 build error"
which is already queued in linux-next.
Regards,
Sudeep
[1] https://lkml.org/lkml/2014/6/24/1024
next prev parent reply other threads:[~2014-09-26 17:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 17:01 [PATCH] perf tools: fix build breakage on arm and arm64 targets Will Deacon
2014-09-26 17:01 ` Will Deacon
2014-09-26 17:19 ` Sudeep Holla [this message]
2014-09-26 17:19 ` Sudeep Holla
2014-09-29 6:59 ` Jean Pihet
2014-09-29 6:59 ` Jean Pihet
2014-09-29 9:22 ` Will Deacon
2014-09-29 9:22 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5425A008.2030901@arm.com \
--to=sudeep.holla@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.